Repository navigation
feat(rocjitsu): package HSA hotswap runtime - #6872
Conversation
|
Depends on ROCm/rocm-systems#9262 |
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
stellaraccident
left a comment
stellaraccident
left a comment
There was a problem hiding this comment.
Given the urgency, we can land like this, but generally we don't arbitrarily extend components like that. We should come back and set it up as its own artifact. Please add such a todo ti te toml file before landing.
|
Can be landed after #6897 (and after ci passes ofcourse) |
Publish libhsa_hotswap_rocjitsu.so as a dedicated rocjitsu artifact component. ROCr's HSA_HOTSWAP_ENABLE=2 mode requires this library, so the HSA hotswap hook must be included in runtime distributions. Keeping it as an independently selectable component lets runtime packages ship the HSA hotswap hook without pulling in the general librocjitsu shared library or introducing a ROCr build or link dependency. The currently validated unstripped shared library is 5,996,136 bytes (approximately 5.72 MiB). Include the component in the rocm-sdk-core wheel, the amdrocm-runtime native package, and base artifact installations. Validate the staged shared library and add focused coverage for wheel selection and base artifact retrieval.
2c34fa0 to
31d1d90
Compare
This PR was marked and closed as stale but I assume another bump landed that ships the base for this? |
Yes |
Created a new artifact instead of leaving a TODO. |
therock-pr-bot
Bot
removed
the
Not ready to Review
| "core-hipinfo_run", | ||
| "core-runtime_run", | ||
| "core-runtime_lib", | ||
| "rocjitsu-hotswap_hook", |
There was a problem hiding this comment.
I don't have enough context on rocjitsu and neither on hotswap but is this really a base requirement to run tests? I bet it is not (as of today).
There was a problem hiding this comment.
It's not needed for tests today yes. But eventually, we plan to choose which backend to make default and if we do make it default any tests on a gfx1250 A0 machine CI won't work, because the runtime will use this library. For context, anything that uses rocr-runtime (almost everything that runs on a gpu) for gfx1250 A0 needs hotswap. The comgr backend is default today, but we might switch to the rocjitsu backend. If any CI decides to use the rocjitsu comgr backend, it will not be able to run tests without this.
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
This looks mostly good, a few NITs.
marbre
changed the title
Publish libhsa_hotswap_rocjitsu.so as a dedicated rocjitsu artifact component. ROCr's HSA_HOTSWAP_ENABLE=2 mode requires this library, so the HSA hotswap hook must be included in runtime distributions.
Keeping it as an independently selectable component lets runtime packages ship the HSA hotswap library without pulling in the general librocjitsu shared library or introducing a ROCr build or link dependency. The currently validated unstripped shared library is 5,996,136 bytes (approximately 5.72 MiB).
Include the component in the rocm-sdk-core wheel, the amdrocm-runtime native package, and base artifact installations. Validate the staged shared library and add focused coverage for wheel selection and base artifact retrieval.
ISSUE ID: ROCm/rocm-systems#8939