Repository navigation
Install aux-overlay directory symlinks with CMake code - #5042
Merged
stellaraccident merged 1 commit intoMay 9, 2026
Merged
Conversation
Partial landing split from #3928. Changes: - Replace install(FILES) for the root llvm and amdgcn directory symlinks with install(CODE) that creates the symlinks at install time. - Create the install prefix inside the install code before creating root-level symlinks; local validation showed the closed #4301 form failed when the prefix did not exist yet. - Leave the existing amdflang symlink behavior unchanged; conditional Fortran symlink handling remains with the split compiler work. Rationale: - CMake install(FILES) rejects directory symlinks, which breaks aux-overlay installation for the SDK layout symlinks tracked by #3714. Validation: - cmake -S base/aux-overlay -B /tmp/therock-aux-overlay-test-build -GNinja -DTHEROCK_SOURCE_DIR=/srv/vm-shared/projects/therock-workspace1/worktrees/TheRock -DTHEROCK_PACKAGE_VERSION=0.0.0 -DGPU_TARGETS=gfx1100 - cmake --build /tmp/therock-aux-overlay-test-build - cmake --install /tmp/therock-aux-overlay-test-build --prefix /tmp/therock-aux-overlay-test-install - verified llvm, amdgcn, and bin/amdclang are symlinks in /tmp/therock-aux-overlay-test-install - git diff --cached --check Generated with Codex
ScottTodd
approved these changes
May 5, 2026
marbre
approved these changes
May 6, 2026
stellaraccident
deleted the
users/stella/pr3928-landing-aux-overlay-symlinks
branch
May 9, 2026 01:43
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial landing split from #3928.
Changes:
Replace install(FILES) for the root llvm and amdgcn directory symlinks with install(CODE) that creates the symlinks at install time.
Create the install prefix inside the install code before creating root-level symlinks; local validation showed the closed [aux-overlay] Use install(CODE) for directory symlinks #4301 form failed when the prefix did not exist yet.
Leave the existing amdflang symlink behavior unchanged; conditional Fortran symlink handling remains with the split compiler work.
Rationale:
Validation:
cmake -S base/aux-overlay -B /tmp/therock-aux-overlay-test-build -GNinja -DTHEROCK_SOURCE_DIR=/srv/vm-shared/projects/therock-workspace1/worktrees/TheRock -DTHEROCK_PACKAGE_VERSION=0.0.0 -DGPU_TARGETS=gfx1100
cmake --build /tmp/therock-aux-overlay-test-build
cmake --install /tmp/therock-aux-overlay-test-build --prefix /tmp/therock-aux-overlay-test-install
verified llvm, amdgcn, and bin/amdclang are symlinks in /tmp/therock-aux-overlay-test-install
git diff --cached --check
Generated with Codex