Skip to content

Trim INTERFACE_*_DIR params from rocprof-trace-decoder #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marbre merged 2 commits into from
Mar 17, 2026
Merged

Trim INTERFACE_*_DIR params from rocprof-trace-decoder #3998

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88cd0c
Fix rocprof-trace-decoder build breakage
ScottTodd Mar 16, 2026
884de47
Add back rocprof-trace-decoder runtime dep
marbre Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions profiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
# SPDX-License-Identifier: MIT

if(THEROCK_ENABLE_ROCPROFV3)
set(_rocprofiler_sdk_common_deps)

set(_openmpi_optional_dep)
if(THEROCK_ENABLE_MPI)
set(_openmpi_optional_dep therock-openmpi)
Expand All @@ -22,13 +20,8 @@ if(THEROCK_ENABLE_ROCPROFV3)
EXTERNAL_SOURCE_DIR "${THEROCK_ROCM_SYSTEMS_SOURCE_DIR}/projects/rocprof-trace-decoder"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/rocprof-trace-decoder"
BACKGROUND_BUILD
INTERFACE_INCLUDE_DIRS
include
INTERFACE_LINK_DIRS
lib
)
therock_cmake_subproject_activate(rocprof-trace-decoder)
list(APPEND _rocprofiler_sdk_common_deps rocprof-trace-decoder)

##############################################################################
# aqlprofile
Expand Down Expand Up @@ -105,8 +98,8 @@ if(THEROCK_ENABLE_ROCPROFV3)
RUNTIME_DEPS
aqlprofile
hip-clr
rocprof-trace-decoder
rocprofiler-register
${_rocprofiler_sdk_common_deps}
${THEROCK_BUNDLED_ELFUTILS}
${THEROCK_BUNDLED_LIBDRM}
${THEROCK_BUNDLED_SQLITE3}
Expand Down Expand Up @@ -153,7 +146,6 @@ if(THEROCK_ENABLE_ROCPROFV3)
aqlprofile
hip-clr
rocprofiler-register
${_rocprofiler_sdk_common_deps}
${THEROCK_BUNDLED_ELFUTILS}
${THEROCK_BUNDLED_LIBDRM}
${THEROCK_BUNDLED_SQLITE3}
Expand Down Expand Up @@ -217,7 +209,7 @@ if(THEROCK_ENABLE_ROCPROFV3)
SUBPROJECT_DEPS
rocprofiler-sdk
roctracer
${_rocprofiler_sdk_common_deps}
rocprof-trace-decoder
)

therock_provide_artifact(rocprofiler-compute
Expand Down
Loading