Trim INTERFACE_*_DIR params from rocprof-trace-decoder#3998
Merged
Conversation
The OSS trace decoder switch (24a1af1) broke builds in two ways: 1. Missing USE_DIST_AMDGPU_TARGETS caused configure failure 2. INTERFACE_INCLUDE_DIRS/INTERFACE_LINK_DIRS leaked transitively through rocprofiler-sdk to consumers in other stages (e.g. composable_kernel, MIOpen), causing -Wmissing-include-dirs errors The trace decoder is a runtime-only dependency (loaded by rocprofv3 --att), so it needs no compile-time interface dirs. Decouple it from the rocprofiler-sdk subproject dependency chain and instead list it directly in the rocprofiler-sdk artifact SUBPROJECT_DEPS for packaging. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Even though rocprof-trace-decoder is _not_ needed at build time the library is dlopened at runtime. While it is sufficient to have it included in the rocprofiler-sdk it is more solid to add it as a runtime dependency.
marbre
approved these changes
Mar 16, 2026
Member
Author
|
We'll wait for CI workflows to get further before merging. Multi-arch CI will remain broken until then. |
Member
|
Windows build failure is unrelated, Linux build passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following up on these PRs:
the build was still broken:
Technical Details
INTERFACE_INCLUDE_DIRS/INTERFACE_LINK_DIRSleaked transitively through rocprofiler-sdk to consumers in other stages (e.g. composable_kernel, MIOpen), causing-Wmissing-include-dirserrorsThe trace decoder appears to be a runtime-only dependency (loaded by
rocprofv3 --att), so it needs no compile-time interface dirs. This decouples it from the rocprofiler-sdk subproject dependency chain and instead lists it directly in the rocprofiler-sdk artifactSUBPROJECT_DEPSfor packaging.Test Plan
Submission Checklist