Skip to content

[hipDNN] Adding hipDNN python packaging#3461

Merged
mousdahl-amd merged 33 commits into
mainfrom
users/mousdahl-amd/hipdnn-python-packaging
Feb 26, 2026
Merged

[hipDNN] Adding hipDNN python packaging#3461
mousdahl-amd merged 33 commits into
mainfrom
users/mousdahl-amd/hipdnn-python-packaging

Conversation

@mousdahl-amd
Copy link
Copy Markdown
Contributor

Motivation

Add hipDNN & MIOpen plugin to the python wheel packaging.
The purpose of this change is to enable hipDNN integration with Pytorch.

This PR supercedes #2958

Technical Details

  • Added hipDNN + plugin project to the packaging script.
  • Added hipdnn to _dist_info.py matching with other libraries
  • Updated documentation to include details of hipDNN
  • Updated build_python_packages.py to allow generic targets to be installed alongside device targets
    • For now this enables hipDNN to be installed alongside other library components.
    • Note: Once RFC0008 is implemented then hipDNN & the plugin should be moved to the host only locations along side the other library projects.

Test Plan

Run a test of the Release portable Linux packages workflow & Windows packages workflow:

Linux test wheels (run here unrelated jax break):

pip install \
  https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425.tar.gz \
  https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm_sdk_core-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-linux_x86_64.whl \
  https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm_sdk_libraries_gfx94x_dcgpu-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-linux_x86_64.whl \
  https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm_sdk_devel-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-linux_x86_64.whl

Windows test wheels (run here):

pip install ^
  https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425.tar.gz ^
  https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm_sdk_core-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-win_amd64.whl ^
  https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm_sdk_libraries_gfx110x_all-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-win_amd64.whl ^
  https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm_sdk_devel-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-win_amd64.whl

Test Result

Wheel builds are successful with the hipDNN artifacts included.
Additional artifacts from hipDNN are present, and installed correctly.

BrianHarrisonAMD and others added 26 commits January 15, 2026 17:39
@mousdahl-amd mousdahl-amd marked this pull request as ready for review February 17, 2026 21:26
@mousdahl-amd
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title to a good commit message (i.e. not starting with the branch name like "Users/[username]")

Comment thread build_tools/build_python_packages.py
Comment thread build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py Outdated
Comment thread build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/devel_test.py Outdated
Comment thread build_tools/build_python_packages.py Outdated
@mousdahl-amd mousdahl-amd changed the title Users/mousdahl amd/hipdnn python packaging [hipDNN] Adding hipDNN python packaging Feb 18, 2026
@mousdahl-amd
Copy link
Copy Markdown
Contributor Author

I'm going to switch this to draft until we can get our frontend flatbuffer dependency sorted out.

@mousdahl-amd mousdahl-amd marked this pull request as draft February 18, 2026 15:50
@mousdahl-amd mousdahl-amd marked this pull request as ready for review February 24, 2026 21:32
@mousdahl-amd
Copy link
Copy Markdown
Contributor Author

Alright @ScottTodd , I think we're ready now!

@ScottTodd
Copy link
Copy Markdown
Member

Can you resolve the conflicts and then re-request review? I might need to find another reviewer for this too, I can't spare much time lately.

@mousdahl-amd
Copy link
Copy Markdown
Contributor Author

We had a green signal before resolving a small conflict with main: https://github.com/ROCm/TheRock/actions/runs/22327111496?pr=3461

Copy link
Copy Markdown
Contributor

@geomin12 geomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, looks like python does build and tests pass for both linux + windows

added a few comments

@mousdahl-amd mousdahl-amd merged commit 5b58daa into main Feb 26, 2026
436 of 451 checks passed
@mousdahl-amd mousdahl-amd deleted the users/mousdahl-amd/hipdnn-python-packaging branch February 26, 2026 15:53
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Feb 26, 2026
mousdahl-amd added a commit that referenced this pull request Mar 2, 2026
## Motivation
Some non-critical PR comments were raised in #3461 , and I didn't want
to hold up the python wheels integration, but I also didn't want to
leave them un-addressed.

## Technical Details
- Corrected the use of the platform.system() call for OS checks
- Added test_plugins to devel checks just for safety

## Test Plan
- CI Passes

## Test Result
- [ ] CI build successfully and tests the ROCm python wheels

## Submission Checklist
- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants