[hipDNN] Adding hipDNN python packaging#3461
Conversation
…OCm/TheRock into users/bharriso/hipdnn-python-packaging
…OCm/TheRock into users/bharriso/hipdnn-python-packaging
…-python-packaging
…-python-packaging
…OCm/TheRock into users/bharriso/hipdnn-python-packaging
…pdnn-python-packaging
|
Successful wheel builds:
Successful wheel tests: https://github.com/ROCm/TheRock/actions/runs/22120355794 |
ScottTodd
left a comment
There was a problem hiding this comment.
Please update the PR title to a good commit message (i.e. not starting with the branch name like "Users/[username]")
…om:ROCm/TheRock into users/mousdahl-amd/hipdnn-python-packaging
|
I'm going to switch this to draft until we can get our frontend flatbuffer dependency sorted out. |
|
Alright @ScottTodd , I think we're ready now! |
|
Can you resolve the conflicts and then re-request review? I might need to find another reviewer for this too, I can't spare much time lately. |
|
We had a green signal before resolving a small conflict with main: https://github.com/ROCm/TheRock/actions/runs/22327111496?pr=3461 |
geomin12
left a comment
There was a problem hiding this comment.
lgtm overall, looks like python does build and tests pass for both linux + windows
added a few comments
## Motivation Some non-critical PR comments were raised in #3461 , and I didn't want to hold up the python wheels integration, but I also didn't want to leave them un-addressed. ## Technical Details - Corrected the use of the platform.system() call for OS checks - Added test_plugins to devel checks just for safety ## Test Plan - CI Passes ## Test Result - [ ] CI build successfully and tests the ROCm python wheels ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Motivation
Add hipDNN & MIOpen plugin to the python wheel packaging.
The purpose of this change is to enable hipDNN integration with Pytorch.
This PR supercedes #2958
Technical Details
Test Plan
Run a test of the Release portable Linux packages workflow & Windows packages workflow:
Linux test wheels (run here unrelated jax break):
Windows test wheels (run here):
Test Result
Wheel builds are successful with the hipDNN artifacts included.
Additional artifacts from hipDNN are present, and installed correctly.