Add hipdnn and miopen-plugin to python packaging#2958
Add hipdnn and miopen-plugin to python packaging#2958BrianHarrisonAMD wants to merge 26 commits into
Conversation
|
The bundling works, but it showed a couple issues we need to address:
We will need to do some changes to resolve the plugin loading issue, and will follow-up with additional PRs to enable this once it's ready. |
|
Attempting to move hipDNN into the libraries install location for now until RFC0008 is implemented. |
adickin-amd
left a comment
There was a problem hiding this comment.
Looks good to me. Can even build hipdnn against the windows wheels!
…OCm/TheRock into users/bharriso/hipdnn-python-packaging
|
Testing was successful with the latest, but seems like some unrelated breaks in other components. |
adickin-amd
left a comment
There was a problem hiding this comment.
New changes look good to me!
…OCm/TheRock into users/bharriso/hipdnn-python-packaging
|
With an update to hipDNN in rocm-libraries, we've got a good signal for rocm wheels tests! Once we land this in rocm-libraries, we're just a submodule bump away from being able to land this PR, I think. https://github.com/ROCm/TheRock/actions/runs/21755726106 |
…-python-packaging
…-python-packaging
…OCm/TheRock into users/bharriso/hipdnn-python-packaging
…-python-packaging
|
I accidentally pushed some submodule bumps when I merged main in, so I've created a new PR that's not ruined forever. #3461 |
|
Closing as superceded by #3461 |
## Motivation Add hipDNN & MIOpen plugin to the python wheel packaging. The purpose of this change is to enable hipDNN integration with Pytorch. This PR supercedes #2958 ## Technical Details - Added hipDNN + plugin project to the packaging script. - Added hipdnn to _dist_info.py matching with other libraries - Updated documentation to include details of hipDNN - Updated build_python_packages.py to allow generic targets to be installed alongside device targets - For now this enables hipDNN to be installed alongside other library components. - Note: Once [RFC0008](https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0008-Multi-Arch-Packaging.md) is implemented then hipDNN & the plugin should be moved to the host only locations along side the other library projects. ## Test Plan Run a test of the Release portable Linux packages workflow & Windows packages workflow: Linux test wheels (run [here](https://github.com/ROCm/TheRock/actions/runs/21262274115/job/61192506091) unrelated jax break): ``` pip install \ https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425.tar.gz \ https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm_sdk_core-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-linux_x86_64.whl \ https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm_sdk_libraries_gfx94x_dcgpu-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-linux_x86_64.whl \ https://therock-dev-python.s3.amazonaws.com/v2/gfx94X-dcgpu/rocm_sdk_devel-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-linux_x86_64.whl ``` Windows test wheels (run [here](https://github.com/ROCm/TheRock/actions/runs/21262292444/job/61192570375)): ``` pip install ^ https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425.tar.gz ^ https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm_sdk_core-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-win_amd64.whl ^ https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm_sdk_libraries_gfx110x_all-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-win_amd64.whl ^ https://therock-dev-python.s3.amazonaws.com/v2-staging/gfx110X-all/rocm_sdk_devel-7.12.0.dev0%2Be7125827ee12837fefbd91de4b3d1a8b9f0b2425-py3-none-win_amd64.whl ``` ## Test Result Wheel builds are successful with the hipDNN artifacts included. Additional artifacts from hipDNN are present, and installed correctly. --------- Co-authored-by: Brian Harrison <brian.harrison@amd.com> Co-authored-by: BrianHarrisonAMD <169072757+BrianHarrisonAMD@users.noreply.github.com>
Motivation
Add hipDNN & MIOpen plugin to the python wheel packaging.
The purpose of this change is to enable hipDNN integration with Pytorch.
Technical Details
Test Plan
Run a test of the Release portable Linux packages workflow & Windows packages workflow:
Linux test wheels (run here unrelated jax break):
Windows test wheels (run here):
Test Result
Wheel builds are successful with the hipDNN artifacts included.
Additional artifacts from hipDNN are present, and installed correctly.