Skip to content

Bump rocm-systems from 0decb2c to a21f844 #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScottTodd merged 3 commits into from
Feb 18, 2026
Merged

Bump rocm-systems from 0decb2c to a21f844 #3423

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
787012f
Bump rocm-systems from `0decb2c` to `360c5c6`
dependabot[bot] Feb 16, 2026
5945dbd
Merge branch 'main' into dependabot/submodules/main/rocm-systems-360c5c6
chiranjeevipattigidi Feb 17, 2026
6e5f645
Bump rocm-systems to latest (mainly for potential amdsmi fix)
ScottTodd Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rocm-systems
Open in desktop
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROCm Python package test case failures for amd-smi on Linux gfx942 look legit? https://github.com/ROCm/TheRock/actions/runs/22090942338/job/63895008079?pr=3423#step:7:41

======================================================================
ERROR: testConsoleScripts (rocm_sdk.tests.core_test.ROCmCoreTest.testConsoleScripts) [Check console-script amd-smi]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/TheRock/TheRock/.venv/lib/python3.12/site-packages/rocm_sdk/tests/core_test.py", line 138, in testConsoleScripts
    output_text = subprocess.check_output(
                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/__w/_tool/Python/3.12.12/x64/lib/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/__w/_tool/Python/3.12.12/x64/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '[PosixPath('/__w/TheRock/TheRock/.venv/bin/amd-smi')]' returned non-zero exit status 1.

The commit history here shows several changes to amdsmi. Do we have more complete logs or test results for amdsmi in particular, or just that sanity check?

Those tests are passing on main for a prior submodule update: https://github.com/ROCm/TheRock/actions/runs/22080712092/job/63813256283

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly fixed by ROCm/rocm-systems@3c85365

Other recent commits: https://github.com/ROCm/rocm-systems/commits/develop/projects/amdsmi

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed another bump to the latest (didn't see an easy way to run bump_submodules or fetch_sources with a partial roll-up, no mention of that in https://github.com/ROCm/TheRock/blob/main/docs/development/git_chores.md 🤔)

Submodule rocm-systems updated 592 files
Loading