Skip to content

Bump build container sha to include changes in #3240 #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lumachad wants to merge 1 commit into from
Closed

Bump build container sha to include changes in #3240 #3249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_native_linux_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
fail-fast: false
runs-on: ${{ github.repository_owner == 'ROCm' && 'azure-linux-scale-rocm' || 'ubuntu-24.04' }}
env:
BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
ARTIFACT_RUN_ID: ${{ inputs.artifact_run_id || github.run_id }}
PACKAGE_SUFFIX: ${{ inputs.package_suffix != '' && inputs.package_suffix || '' }}
OUTPUT_DIR: ${{ github.workspace }}/output
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_portable_linux_artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
# --cap-add=SYS_PTRACE : to enable ptrace insided the build container for tsan builds
# --security-opt seccomp=unconfined : to disable the system call filtering for tsan builds
options: -v /runner/config:/home/awsconfig/ --cap-add=SYS_PTRACE --security-opt seccomp=unconfined
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_portable_linux_python_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
outputs:
package_find_links_url: ${{ steps.upload.outputs.package_find_links_url }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_portable_linux_pytorch_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
name: Build | ${{ inputs.amdgpu_family }} | py ${{ inputs.python_version }} | torch ${{ inputs.pytorch_git_ref }}
runs-on: ${{ github.repository_owner == 'ROCm' && 'azure-linux-scale-rocm' || 'ubuntu-24.04' }}
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
env:
OUTPUT_DIR: ${{ github.workspace }}/output
PACKAGE_DIST_DIR: ${{ github.workspace }}/output/packages/dist
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_portable_linux_pytorch_wheels_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
name: Build PyTorch | ${{ inputs.artifact_group }} | torch ${{ inputs.pytorch_git_ref }} | py${{ inputs.python_version }}
runs-on: ${{ github.repository_owner == 'ROCm' && 'azure-linux-scale-rocm' || 'ubuntu-24.04' }}
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
env:
PACKAGE_DIST_DIR: ${{ github.workspace }}/output/packages/dist
optional_build_prod_arguments: ""
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/multi_arch_build_portable_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ permissions:
contents: read

env:
CONTAINER_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
CONTAINER_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
CCACHE_CONFIGPATH: ${{ github.workspace }}/.ccache/ccache.conf
CACHE_DIR: ${{ github.workspace }}/.container-cache
TEATIME_FORCE_INTERACTIVE: 0
Expand All @@ -69,7 +69,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
env:
AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
env:
AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini
Expand Down Expand Up @@ -266,7 +266,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
env:
AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini
Expand Down Expand Up @@ -378,7 +378,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
env:
AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini
Expand Down Expand Up @@ -486,7 +486,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
env:
AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini
Expand Down Expand Up @@ -590,7 +590,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
env:
AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini
Expand Down Expand Up @@ -694,7 +694,7 @@ jobs:
permissions:
id-token: write
container:
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
options: -v /runner/config:/home/awsconfig/
env:
AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_portable_linux_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
env:
TEATIME_LABEL_GH_GROUP: 1
OUTPUT_DIR: ${{ github.workspace }}/output
BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb
BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee
DIST_ARCHIVE: "${{ github.workspace }}/output/therock-dist-linux-${{ matrix.target_bundle.amdgpu_family }}${{ inputs.package_suffix }}-${{ needs.setup_metadata.outputs.version }}.tar.gz"
FILE_NAME: "therock-dist-linux-${{ matrix.target_bundle.amdgpu_family }}${{ inputs.package_suffix }}-${{ needs.setup_metadata.outputs.version }}.tar.gz"
RELEASE_TYPE: "${{ needs.setup_metadata.outputs.release_type }}"
Expand Down
2 changes: 1 addition & 1 deletion build_tools/linux_portable_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def main(argv: list[str]):
p.add_argument("--docker", default="docker", help="Docker or podman binary")
p.add_argument(
"--image",
default="ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb",
default="ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee",
help="Build docker image",
)
p.add_argument(
Expand Down
2 changes: 1 addition & 1 deletion docs/environment_setup_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Based on upstream: AlmaLinux 8 with gcc toolset 13

While this generally implies that the project should build on similarly versioned alternative EL distributions, do note that we install several upgraded tools (see dockerfile above) in our standard CI pipelines.

Reference image: `ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:6e8242d347af7e0c43c82d5031a3ac67b669f24898ea8dc2f1d5b7e4798b66bd`
Reference image: `ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee`

### Ubuntu 22.04

Expand Down
2 changes: 1 addition & 1 deletion external-builds/uccl/build_prod_wheels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def main(argv: list[str]):

p.add_argument(
"--image",
default="ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb",
default="ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee",
help="Base docker image for UCCL's build",
)
p.add_argument(
Expand Down
Loading