Repository navigation
Introduce CODEOWNERS for reviewer assignment of submodule updates - #2487
Merged
Merged
Conversation
ScottTodd
commented
Dec 9, 2025
Comment on lines
+1
to
+3
| # Regularly updated submodules | ||
| /rocm-libraries/ @ROCm/TheRockInfra | ||
| /rocm-systems/ @ROCm/TheRockInfra |
Member
Author
There was a problem hiding this comment.
We can add other entries here later. I'm thinking of at least this one:
# Build containers that need careful review
/dockerfiles/build_* @stellaraccidentI'm also tempted to add myself for
docs/patches/external-builds/pytorch/
I feel like I've been keeping a close enough eye on the repository with the current PR load that CODEOWNERS isn't really needed yet though.
Other areas that we could consider owners for (due to how sensitive some parts of these subtrees are architecturally):
.github/workflows/build_tools/packaging/cmake/third-party/third-party/sysdeps/
Contributor
There was a problem hiding this comment.
I agree with CODEOWNERS being added to other areas as well. in fact having CODEOWNERs to entire build_tools/ would be good.
marbre
approved these changes
Dec 9, 2025
amd-shiraz
approved these changes
Dec 9, 2025
Contributor
|
I asked @amd-aakash to include the monitoring team on approving submodule bumps if they observe the PRs passing CI during their work hours. |
rponnuru5
pushed a commit
that referenced
this pull request
Dec 12, 2025
) Progress on #223. As reported at #2400 (comment), dependabot no longer supports the `reviewers` field and instead suggests that projects use `CODEOWNERS`: https://github.blog/changelog/2025-04-29-dependabot-reviewers-configuration-option-being-replaced-by-code-owners/.
ScottTodd
added a commit
that referenced
this pull request
Dec 12, 2025
Follow-up to #2487. See #2520 (comment) - this was not assigning reviewers as expected. I'm not sure how to test this...
subodh-dubey-amd
pushed a commit
that referenced
this pull request
Dec 15, 2025
) Progress on #223. As reported at #2400 (comment), dependabot no longer supports the `reviewers` field and instead suggests that projects use `CODEOWNERS`: https://github.blog/changelog/2025-04-29-dependabot-reviewers-configuration-option-being-replaced-by-code-owners/.
subodh-dubey-amd
pushed a commit
that referenced
this pull request
Dec 15, 2025
Follow-up to #2487. See #2520 (comment) - this was not assigning reviewers as expected. I'm not sure how to test this...
benrichard-amd
pushed a commit
to benrichard-amd/TheRock
that referenced
this pull request
Jan 5, 2026
…Cm#2487) Progress on ROCm#223. As reported at ROCm#2400 (comment), dependabot no longer supports the `reviewers` field and instead suggests that projects use `CODEOWNERS`: https://github.blog/changelog/2025-04-29-dependabot-reviewers-configuration-option-being-replaced-by-code-owners/.
benrichard-amd
pushed a commit
to benrichard-amd/TheRock
that referenced
this pull request
Jan 5, 2026
Follow-up to ROCm#2487. See ROCm#2520 (comment) - this was not assigning reviewers as expected. I'm not sure how to test this...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #223.
As reported at #2400 (comment), dependabot no longer supports the
reviewersfield and instead suggests that projects useCODEOWNERS: https://github.blog/changelog/2025-04-29-dependabot-reviewers-configuration-option-being-replaced-by-code-owners/.