Skip to content

Conversation

@erman-gurses
Copy link
Contributor

@erman-gurses erman-gurses commented Nov 18, 2025

Motivation

Closes: #2072

Technical Details

Related PR: #2045

Test Plan

Test on local and CI

Test Result

Submission Checklist

@erman-gurses erman-gurses changed the title Move amdsmi subproject from base/amdsmi to core/amdsmi Move amdsmi subproject from base/amdsmi to core/amdsmi Nov 18, 2025
@erman-gurses erman-gurses marked this pull request as ready for review November 19, 2025 00:05
@stellaraccident
Copy link
Collaborator

I'm not opposed to the move, but moving submodules around is annoying/messy. Any reason why amdsmi isn't in rocm-systems yet? Doing that first would be the logical first step.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to the move, but moving submodules around is annoying/messy. Any reason why amdsmi isn't in rocm-systems yet? Doing that first would be the logical first step.

Is amdsmi migrated now? I see it in https://github.com/ROCm/rocm-systems/tree/develop/projects/amdsmi, but https://github.com/ROCm/rocm-systems/?tab=readme-ov-file#super-repo-status-and-ci-health still lists it as "pending".

I also see that our rocm-systems submodule in TheRock has some sources for amdsmi. Can we first switch the existing amdsmi subproject to the new source and then proceed with this PR?

  1. Delete the amdsmi submodule
  2. Point this code at ${THEROCK_ROCM_SYSTEMS_SOURCE_DIR}/projects/amdsmi:
    EXTERNAL_SOURCE_DIR "amdsmi"
  3. Send that as one PR
  4. Rebase this PR after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

Move amdsmi from 'base/' folder and artifact to 'amdsmi' artifact in 'core/'

4 participants