Move non-sysdep third-party projects after base and compiler.

[ScottTodd]

Motivation

Progress on #1822. Fixes #2003.

Technical Details

This splits third-party into sysdeps and application libraries:

• sysdeps are needed to build the compiler and must be built using the system toolchain (MSVC on Windows)
• application libraries can/should be built using a clang toolchain

This is a step towards a larger bootstrapping effort where we should first build the compiler than use it consistently for all subprojects.

After the split, it is now possible to use the amd-llvm toolchain to build non-sysdep third-party projects. That is required for spdlog on Windows, due to how spdlog sets the /Zc:__cplusplus flag for MSVC (see the code here) and we don't want that propagating to later builds using clang.

Test Plan

Built spdlog and tried building rocroller and hipdnn on Windows.

Test Result

rocroller and hipdnn had more compilation issues that can be fixed after this.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[ScottTodd]

amdsmi (which is Linux only) in base/ depends on therock-googletest which is not a sysdep, see https://github.com/ROCm/TheRock/actions/runs/19153803999/job/54750039189?pr=2045#step:10:119

-- Including subproject amdsmi (from /__w/TheRock/TheRock/base/amdsmi)
--   PROVIDE amd_smi = lib/cmake (from amdsmi)
--   RUNTIME_DEPS: rocm-core therock-libdrm
--   INJECT rocm-core = /__w/TheRock/TheRock/build/base/rocm-core/dist/lib/cmake/rocm-core (from rocm-core)
CMake Error at cmake/therock_subproject.cmake:1026 (get_target_property):
  get_target_property() called with non-existent target "therock-googletest".
Call Stack (most recent call first):
  cmake/therock_subproject.cmake:1039 (_therock_assert_is_cmake_subproject)
  cmake/therock_subproject.cmake:667 (_therock_cmake_subproject_setup_deps)
  base/CMakeLists.txt:76 (therock_cmake_subproject_activate)

Code:

TheRock/base/CMakeLists.txt

Lines 61 to 69 in 77e4a83

	therock_cmake_subproject_declare(amdsmi
	EXTERNAL_SOURCE_DIR "amdsmi"
	USE_DIST_AMDGPU_TARGETS
	BACKGROUND_BUILD
	CMAKE_ARGS
	# TODO: Enable tests
	# -DBUILD_TESTS=${THEROCK_BUILD_TESTING}
	BUILD_DEPS
	therock-googletest

This will need more work on Linux in that case

[ScottTodd]

Looks like we can either

1. Move therock-googletest to 'sysdeps'
2. Move amdsmi and rocm_smi_lib from 'base' to 'core'

I'm leaning towards (2) architecturally (since the libraries may expect googletest to be compiled with clang too), though (1) looks easier in the context of this PR.

[stellaraccident]

Let's do 2 and should be fine. That will also solve a problem for me with respect to enabling ASAN for amdsmi (which depends on the clang toolchain).

If we do that, we should create an amdsmi artifact vs lumping it into "base". It needs to be its own and will need its own package, etc (so I think this was done as-is in error).

I'd love to further eliminate base/ entirely but we can get there eventually.

[ScottTodd]

Okay, can proceed with (2).

I'm also trying a third option: fiddle with the include order even further for just googletest. Might be able to unblock bringup work for rocroller and hipdnn on Windows faster that way.

[ScottTodd]

Filed #2072 (assigned to @erman-gurses ) for moving amdsmi to 'core'. The include order hack for just googletest did pass CI here, so we could proceed with this if we don't want to wait for moving amdsmi around.