Allow targetid for mcpu kernel arguments#3699
Closed
cderb wants to merge 14 commits into
Closed
Conversation
cderb
requested review from
BradPepersAMD,
BrianHarrisonAMD,
JonathanLichtnerAMD and
adickin-amd
as code owners
averinevg
reviewed
May 5, 2025
Comment on lines
+530
to
+534
| // Probably, according to the idea of the author of this test, the number of CUs should have been | ||
| // substituted with the value passed to the constructor (which in fact did not happen). After | ||
| // https://github.com/ROCm/MIOpen/pull/3175, the method became virtual, the substitution actually | ||
| // happened, and the test broke. I disabled that part (since it doesn't work as intended anyway) to | ||
| // keep its behavior the same. |
Contributor
There was a problem hiding this comment.
This comment and the #if/#endif can be removed. I wrote the comment and disabled the code below, but now it is enabled again, someone probably fixed it.
Contributor
Author
There was a problem hiding this comment.
I'll remove the comment and #defs.
| #include <string> | ||
|
|
||
| #define WORKAROUND_ISSUE_3001 1 | ||
| #define WORKAROUND_ISSUE_3001 0 |
Contributor
There was a problem hiding this comment.
Can this be removed?
BrianHarrisonAMD
previously approved these changes
Jul 24, 2025
Contributor
BrianHarrisonAMD
left a comment
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
LGTM, but probably need to update, and re-run CI.
|
Imported to ROCm/rocm-libraries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issue for generating system kdb #3001
unblock #2891 resolving #2851