-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"-mno-xnack" flag is removed by upstream clang #2851
Comments
@littlewu2508 Yep, it seems like after some recent changes in the compiler, I'll look into this. But please let us know hot urgent/important is this issue for you.
|
optAsm.emplace_back("-mno-xnack"); |
And also, why MIOpen has its own comgr, rather than using https://github.com/ROCm/ROCm-CompilerSupport?
The mno-xnack is removed in upstream clang
It was removed from HIP compiler, but we use it for AMDGPU assembler.
And also, why MIOpen has its own comgr, rather than using https://github.com/ROCm/ROCm-CompilerSupport?
MIOpen uses COMgr and HIPRTC libs to build kernels, no "its own" comgr.
The mno-xnack is removed in upstream clang
It was removed from HIP compiler, but we use it for AMDGPU assembler.
Understood. So I think maybe we can remove the "-target-feature"
, "-xnack"
from optAsm
.
@littlewu2508 I am going to provide a fix for this issue soon. Please let me know if offline assembly (i.e. when the library uses clang executable directly) is working fine on your system. How to switch from online to offline kernel compilation: just pass two additional options ( |
@littlewu2508 #2891 created. Here is the diff if you would like to try it ASAP: https://github.com/ROCm/MIOpen/compare/develop...atamazov:gcnasm-noxnack-etc.diff |
Thanks! I backported it to 5.7 and it resolves the issue of unknown |
@littlewu2508 in order to close this we also need #2891 to be merged in, so I suggest reopening this. |
You're right, this is not merged in develop branch yet |
@junliume Please reopen this due to merged #3002. @littlewu2508 To get the fix back, you can change value of WORKAROUND_ISSUE_3001 (see #3002) to 0 and rebuild the library. |
Building and testing MIOpen with upstream clang, I got some failures. One is
test_conv2d
:The output of
AMD_COMGR_SAVE_TEMPS=1 AMD_COMGR_REDIRECT_LOGS=stdout AMD_COMGR_EMIT_VERBOSE_LOGS=1 /run/user/18014/portage/sci-libs/miopen-5.7.1-r1/work/MIOpen-rocm-5.7.1_build/bin/test_conv2d --float --cmode conv --pmode valid --group-count 1 --batch_size 8 --input_channels 32 --output_channels 32 --spatial_dim_elements 28 28 --filter_dims 5 5 --pads_strides_dilations 1 1 1 1 1 1 --trans_output_pads 0 0 --in_layout NCHW --fil_layout NCHW --out_layout NCHW --deterministic 0 --tensor_vect 0 --vector_length 1 --output_type int32 --int8_vectorize 0
is:miopen-test_conv2d-comgr.log
Original post is in #990 (comment) which points out that
-mno-xnack
is not supported by upstream clang. Maybe we should remove the "-target-feature", "-xnack" fromoptAsm
rather than adding a-mno-xnack
The text was updated successfully, but these errors were encountered: