Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all CSS features #275

Closed
wants to merge 1 commit into from
Closed

Add support for all CSS features #275

wants to merge 1 commit into from

Conversation

RJWadley
Copy link
Owner

This PR updates to my forked version of doiuse that supports all CSS features currently in the caniuse-lite database. The switch is plug and play.

I've submitted a pull request to the original doiuse repo, but it's worth noting that the project isn't actively maintained. I'll be maintaining the forked version for the time being. For more context, or to see a summary of the changes, check out the relevant pull request.

@ismay
Copy link
Collaborator

ismay commented May 16, 2023

Thanks for the PR, that's great work! So doiuse is looking for (a) new maintainer(s). There's some discussion on that topic here: #267. clshortfuse mentioned he wouldn't mind helping out and it seemed like anandthakker was open to the idea.

That discussion has stalled a bit, but I think it would be ideal if you and clshortfuse could integrate your work into the original doiuse instead of us having to fork it. How about I ping Anand, and then if we can't move ahead within a reasonable timeframe we'll go with the fork. Does that sound good to you?

@RJWadley
Copy link
Owner Author

RJWadley commented May 16, 2023

That sounds great, I'd much prefer to consolidate everything into the original doiuse repository.

All the work I've done has been built on top of the great work clshortfuse has done. For reference, here's the PR that merges clshortfuse's work, and here's one with the changes I've made.

@ismay
Copy link
Collaborator

ismay commented May 23, 2023

Good to see the work on doiuse progressing! Let me know when anandthakker/doiuse#159 has been merged and we can look at updating doiuse here.

@ismay
Copy link
Collaborator

ismay commented Jul 7, 2023

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ismay ismay added the released label Jul 7, 2023
@ismay
Copy link
Collaborator

ismay commented Jul 7, 2023

Thanks for the work you've put into doiuse @RJWadley!

@ismay
Copy link
Collaborator

ismay commented Aug 12, 2023

Hey @RJWadley, this is a bit out of the blue, but would you be interested in taking over stylelint-no-unsupported-browser-features? I no longer really have the time to maintain it so I'm looking for a new maintainer. Let me know if you'd be interested!

@RJWadley
Copy link
Owner Author

Sure, I'd be interested.

@ismay
Copy link
Collaborator

ismay commented Aug 13, 2023

Nice, that's good to hear. Shall I transfer the GH repo and the npm module to you? I'm assuming https://www.npmjs.com/~rjwadley is your npm account? Let me know what you'd prefer.

@RJWadley
Copy link
Owner Author

Sure, that sounds good to me. And that is my npm account. Is there anything else I should be aware of?

@ismay
Copy link
Collaborator

ismay commented Aug 14, 2023

Is there anything else I should be aware of?

Only these minor things:

  • There's a 5.x branch for backports to v5. Someone opened a PR a while back because they were stuck on a particular node version and needed a fix for that version. I opened the branch but didn't hear back from them, so you could just remove it.
  • The repo uses semantic release for automated releases, changelog generation, etc. See the action here. This requires two env vars, GH_TOKEN and NPM_TOKEN. These are tied to my accounts, so I won't transfer them over. If you want to keep the automated releases you can supply your own gh and npm token and it should all work out of the box.
  • Codecov is linked to my gh account. If you want to keep using that you'll need a free account with them.
  • The github and codecov badges in the readme link to my gh and codecov account, those will need to be updated.
  • I've used renovate to keep dependencies up to date, config is here. It's linked to my account, so if you want to continue using it you'll need a free account with them.

The above depends on your preferences of course, you could also use different tooling. I've updated any other things that referred to me, like the package.json author fields, etc. Let me know if you have any questions!

@ismay
Copy link
Collaborator

ismay commented Aug 14, 2023

Oh one other thing. In order to transfer the repo you'll need to delete your fork of stylelint-no-unsupported-browser-features first. Once you've done that I'll be able to transfer the repo over.

@RJWadley
Copy link
Owner Author

I've deleted my fork. Thanks for all the info.

@ismay
Copy link
Collaborator

ismay commented Aug 14, 2023

I've deleted my fork. Thanks for all the info.

Sure thing, happy to help 👍. And thank you for adopting the project! I've initiated the transfer of both the npm module and the github repo to your accounts. You should have received notifications for both, let me know if you haven't or if you have questions!

@ismay
Copy link
Collaborator

ismay commented Aug 15, 2023

All right, that's everything transferred 😊🎉. Feel free to ping me if there's anything I can help out with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants