Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/posix_sleep: fix for invalid RTT configurations [backport 2021.01] #15876

Merged
merged 3 commits into from
Jan 28, 2021
Merged

tests/posix_sleep: fix for invalid RTT configurations [backport 2021.01] #15876

merged 3 commits into from
Jan 28, 2021

Conversation

fjmolinas
Copy link
Contributor

Backport of #15794

Contribution description

While testing RIOT-OS/Release-Specs#202 I found that posix_sleep was failing because of invalid RTT configurations. The proper fix is different than the one proposed here, I think it would mean adding a feature, but for a realease backport this is IMO the smallest change.

Testing procedure

Test on iotab-m3 now passes same for any kinetis or efm32 BOARD.

@fjmolinas
boards/common/iotlab: change default RTT_FREQUENCY to RTT_MAX_FREQUENCY
dcef3bc 
(cherry picked from commit 69659ef)
@fjmolinas
boards/common/arduino-zero: configure RTT_MIN_OFFSET
6a4590b 
(cherry picked from commit 4c9a2d7)
@fjmolinas
tests/posix_sleep: dont use periph_rtt for efm32 and kinetis
d9cf7d4 
These CPU families have a non configurable RTT of 1Hz, not enough for
ztimer_msec to run on periph_rtt.

(cherry picked from commit bafcaec)
@fjmolinas fjmolinas added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 28, 2021
@fjmolinas fjmolinas mentioned this pull request Jan 28, 2021
Merged
jia200x
jia200x approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x jia200x mentioned this pull request Jan 28, 2021
Closed
88 tasks
@jia200x jia200x merged commit 36e102a into RIOT-OS:2021.01-branch Jan 28, 2021
@fjmolinas fjmolinas deleted the backport/2021.01/pr_fix_posix_sleep branch July 30, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjmolinas @jia200x