tests/posix_sleep: fix for invalid RTT configurations #15794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
Type: bug
fjmolinas
requested review from
aabadie,
leandrolanzieri,
MichelRottleuthner and
smlng
as code owners
These CPU families have a non configurable RTT of 1Hz, not enough for ztimer_msec to run on periph_rtt.
fjmolinas
added
the
CI: ready for build
fjmolinas
force-pushed
the
pr_fix_posix_sleep
branch
from
308b859 to
bafcaec
Compare
|
ping @aabadie :) |
aabadie
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
works on iotlab-m3
make BOARD=iotlab-m3 -C tests/posix_sleep flash test IOTLAB_NODE=auto-ssh
make: Entering directory '/work/riot/RIOT/tests/posix_sleep'
Building application "tests_posix_sleep" for "iotlab-m3" with MCU "stm32".
"make" -C /work/riot/RIOT/boards/iotlab-m3
"make" -C /work/riot/RIOT/boards/common/iotlab
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/cpu/stm32
"make" -C /work/riot/RIOT/cpu/cortexm_common
"make" -C /work/riot/RIOT/cpu/cortexm_common/periph
"make" -C /work/riot/RIOT/cpu/stm32/periph
"make" -C /work/riot/RIOT/cpu/stm32/stmclk
"make" -C /work/riot/RIOT/cpu/stm32/vectors
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/frac
"make" -C /work/riot/RIOT/sys/isrpipe
"make" -C /work/riot/RIOT/sys/malloc_thread_safe
"make" -C /work/riot/RIOT/sys/newlib_syscalls_default
"make" -C /work/riot/RIOT/sys/pm_layered
"make" -C /work/riot/RIOT/sys/posix/sleep
"make" -C /work/riot/RIOT/sys/stdio_uart
"make" -C /work/riot/RIOT/sys/test_utils/interactive_sync
"make" -C /work/riot/RIOT/sys/tsrb
"make" -C /work/riot/RIOT/sys/ztimer
text data bss dec hex filename
12288 176 2520 14984 3a88 /work/riot/RIOT/tests/posix_sleep/bin/iotlab-m3/tests_posix_sleep.elf
iotlab-node --jmespath='keys(@)[0]' --format='int' --list saclay,m3,1 --flash /work/riot/RIOT/tests/posix_sleep/bin/iotlab-m3/tests_posix_sleep.bin | grep 0
0
r
ssh -t [email protected] 'socat - tcp:m3-1.saclay.iot-lab.info:20000'
READY
s
START
main(): This is RIOT! (Version: 2021.04-devel-68-gbafca-review_posix_sleep)
5 x usleep(i++ * 500000)
wake up
wake up
wake up
wake up
wake up
5 x sleep(i++)
wake up
wake up
wake up
wake up
wake up
DONE
works on arduino-zero
make BOARD=arduino-zero -C tests/posix_sleep flash test IOTLAB_NODE=auto-ssh
make: Entering directory '/work/riot/RIOT/tests/posix_sleep'
Building application "tests_posix_sleep" for "arduino-zero" with MCU "samd21".
"make" -C /work/riot/RIOT/boards/arduino-zero
"make" -C /work/riot/RIOT/boards/common/arduino-zero
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/cpu/samd21
"make" -C /work/riot/RIOT/cpu/cortexm_common
"make" -C /work/riot/RIOT/cpu/cortexm_common/periph
"make" -C /work/riot/RIOT/cpu/sam0_common
"make" -C /work/riot/RIOT/cpu/sam0_common/periph
"make" -C /work/riot/RIOT/cpu/samd21/periph
"make" -C /work/riot/RIOT/cpu/samd21/vectors
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/frac
"make" -C /work/riot/RIOT/sys/isrpipe
"make" -C /work/riot/RIOT/sys/malloc_thread_safe
"make" -C /work/riot/RIOT/sys/newlib_syscalls_default
"make" -C /work/riot/RIOT/sys/pm_layered
"make" -C /work/riot/RIOT/sys/posix/sleep
"make" -C /work/riot/RIOT/sys/stdio_uart
"make" -C /work/riot/RIOT/sys/test_utils/interactive_sync
"make" -C /work/riot/RIOT/sys/tsrb
"make" -C /work/riot/RIOT/sys/ztimer
text data bss dec hex filename
13088 176 2516 15780 3da4 /work/riot/RIOT/tests/posix_sleep/bin/arduino-zero/tests_posix_sleep.elf
iotlab-node --jmespath='keys(@)[0]' --format='int' --list saclay,arduino-zero,1 --flash /work/riot/RIOT/tests/posix_sleep/bin/arduino-zero/tests_posix_sleep.bin | grep 0
0
r
ssh -t [email protected] 'socat - tcp:arduino-zero-1.saclay.iot-lab.info:20000'
READY
s
START
main(): This is RIOT! (Version: 2021.04-devel-68-gbafca-review_posix_sleep)
5 x usleep(i++ * 500000)
wake up
wake up
wake up
wake up
wake up
5 x sleep(i++)
wake up
wake up
wake up
wake up
wake up
DONE
I don't have a kinetis and efm32 for testing but I trust your testing.
ACK
88 tasks
|
@fjmolinas this one still needs a backport ! |
|
Backport provided in #15876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
While testing RIOT-OS/Release-Specs#202 I found that
posix_sleepwas failing because of invalid RTT configurations. The proper fix is different than the one proposed here, I think it would mean adding a feature, but for a realease backport this is IMO the smallest change.Testing procedure
Test on
iotab-m3now passes same for anykinetisorefm32BOARD.