Appeng 4903/tekton triggers and validate task - #2
Merged
Conversation
dmartinol
reviewed
Apr 13, 2026
dmartinol
left a comment
dmartinol
left a comment
There was a problem hiding this comment.
we need an examples folder and a quick document to understand the requirements to trigger these flows
GuyZivRH
added a commit
that referenced
this pull request
Apr 13, 2026
- Add examples/sample_skill/ with minimal valid submission - Add Docs/trigger_guide.md covering webhook flow, manual triggers, CEL interceptor, and submission contract - Add clarifying comment in validate.yaml explaining the workspace size check is a resource guard (not a minimum content check) Addresses review feedback on PR #2. Made-with: Cursor
Collaborator
Author
|
1864374 |
- EventListener with CEL interceptor filtering submissions/ path - TriggerBinding extracting repo URL, revision, and skill directory - TriggerTemplate creating PipelineRun with workspace PVC - Validation task with workspace size guard and structured JSON results Made-with: Cursor
- Clone pipeline repo (SkillsEvalFlow) as a separate step so validate.py is available in the two-repo model - Fix bash path injection by using sys.argv instead of interpolation - Document single-skill-per-push assumption in EventListener overlay Made-with: Cursor
- Add examples/sample_skill/ with minimal valid submission - Add Docs/trigger_guide.md covering webhook flow, manual triggers, CEL interceptor, and submission contract - Add clarifying comment in validate.yaml explaining the workspace size check is a resource guard (not a minimum content check) Addresses review feedback on PR #2. Made-with: Cursor
GuyZivRH
force-pushed
the
APPENG-4903/tekton-triggers-and-validate-task
branch
from
April 14, 2026 07:33
1864374 to
b9c55a2
Compare
4 tasks
GuyZivRH
added a commit
that referenced
this pull request
Apr 23, 2026
Update harbor_openshift_backend.md to match the current state of the Harbor fork (PRs #1 and #2): - Document both eval modes (prebuilt + local-build via podman) - Fix file path: openshift.py, not openshift_environment.py - Correct Pod security: readOnlyRootFilesystem intentionally unset, HOME=/tmp injected instead - Narrow RBAC table to actual usage (Pods, exec, log, Secrets, Events) - Update naming to treatment/control throughout - Add environment kwargs table (namespace, image_ref, registry, cpu_request, tls_verify) - Document per-task environment_kwargs (fork PR #2) - Document K8s client manager refactor for concurrent safety (fork PR #2) - Update Definition of Done with completed items Update harbor_fork_requirements.md to reflect per-task environment_kwargs as implemented (no longer nice-to-have).
5 tasks
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #1 (must be merged first)