Skip to content

Appeng 4904/phase 2 scaffolding - #3

Merged
GuyZivRH merged 2 commits into
mainfrom
APPENG-4904/phase-2-scaffolding
Apr 14, 2026
Merged

Appeng 4904/phase 2 scaffolding#3
GuyZivRH merged 2 commits into
mainfrom
APPENG-4904/phase-2-scaffolding

Conversation

@GuyZivRH

Copy link
Copy Markdown
Collaborator

No description provided.

@GuyZivRH
GuyZivRH requested review from dmartinol and r2dedios April 13, 2026 07:12
Comment thread pipeline/tasks/scaffold.yaml
dmartinol
dmartinol previously approved these changes Apr 14, 2026

@dmartinol dmartinol left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Jinja2 templates (Dockerfile, test.sh, task.toml) render based on
submission metadata and directory inspection. scaffold.py produces
two task directories matching Harbor's expected structure with
skills_dir for the skilled variant only.

Includes review fixes: UBI9-compatible dnf, valid TOML with
llm_judge, reward file written on test failure, configurable
timeouts/resources from metadata.yaml, scripts/ dir support.

25 unit tests covering both variants, optional dirs, TOML validity,
custom timeouts, minimal metadata, and edge cases.

Made-with: Cursor
OpenShift restricted-v2 SCC runs containers as non-root, so dnf
and curl installs fail at runtime. Move installation to the
Dockerfile build layer with UV_INSTALL_DIR=/usr/local/bin for
system-wide PATH availability. Remove runtime install from test.sh.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants