Skip to content

fix(web-shell): use theme color for @ group titles #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BZ-D merged 1 commit into from
Jul 4, 2026
Merged

fix(web-shell): use theme color for @ group titles #6294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web-shell/client/components/Editor.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@
margin: 6px 10px 4px;
padding: 2px 0 4px !important;
line-height: 1.2;
color: var(--muted-foreground, #a1a1aa) !important;

@qwen-code-ci-bot qwen-code-ci-bot Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] The fallback value #a1a1aa doesn't match either theme definition (#808598 dark / #a3a3a5 light) and is inconsistent with every other var(--muted-foreground) usage in the codebase, all of which omit the fallback since syncTheme() always propagates the variable to the tooltip portal.

Suggested change
color: var(--muted-foreground, #a1a1aa) !important;
color: var(--muted-foreground) !important;

Same applies to the identical line in useComposerCore.ts.

— qwen3.7-max via Qwen Code /review

border-bottom: 1px solid var(--border) !important;
}

Expand Down
1 change: 1 addition & 0 deletions packages/web-shell/client/hooks/useComposerCore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ const TOOLTIP_STYLES = `
margin: 6px 10px 4px;
padding: 2px 0 4px !important;
line-height: 1.2;
color: var(--muted-foreground, #a1a1aa) !important;
border-bottom: 1px solid var(--border) !important;
}

Expand Down
Loading