fix(web-shell): use theme color for @ group titles - #6294
Merged
Conversation
Collaborator
|
Thanks for the PR! Template looks good ✓ Problem: This is a plausible visual issue — without an explicit Direction: Aligned. Using the existing Approach: Minimal — two lines added to two rendering paths (CSS module + inline TOOLTIP_STYLES), both targeting the same One question: the fallback Moving on to code review. 🔍 中文说明感谢贡献！ 模板完整 ✓ 问题： 这是一个合理的视觉问题—— 方向： 对齐。使用已有的 方案： 最小改动——在两处渲染路径（CSS module + 内联 TOOLTIP_STYLES）各加一行，都针对同一个 一个小问题：fallback 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Collaborator
Code ReviewThe diff is two identical one-line additions — The Reuse check: No blockers. TestingThis is a browser-rendered CSS change in the web-shell — tmux/CLI testing doesn't apply here. What I could verify:
Visual verification (dark theme + 中文说明代码审查diff 是两行相同的添加——
复用检查： 无阻塞问题。 测试这是 web-shell 中浏览器渲染的 CSS 变更——tmux/CLI 测试不适用。已验证的内容：
视觉验证（暗色主题 + — Qwen Code · qwen3.7-max |
Collaborator
|
This is about as clean as a CSS fix gets. Two lines, two rendering paths that already had identical rules, one existing theme variable. The problem is visible in the code (no I would have done the same thing. Nothing to simplify, nothing to cut. The only thing I'd flag for the author's awareness: no before/after screenshot was included, which would have made this an even easier review. For future visual fixes, a quick screenshot goes a long way. Approving. ✅ 中文说明这是一个非常干净的 CSS 修复。两行代码，两个已经存在相同规则的渲染路径，一个已有的主题变量。问题在代码中就能看到（ 我也会做同样的改动。没有需要简化的，没有需要砍掉的。 唯一想提醒作者的是：没有附带 before/after 截图，如果有截图会让审查更轻松。以后的视觉修复建议随手截个图。 批准。✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
approved these changes
Jul 4, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
wenshao
approved these changes
Jul 4, 2026
| margin: 6px 10px 4px; | ||
| padding: 2px 0 4px !important; | ||
| line-height: 1.2; | ||
| color: var(--muted-foreground, #a1a1aa) !important; |
Collaborator
There was a problem hiding this comment.
[Suggestion] The fallback value #a1a1aa doesn't match either theme definition (#808598 dark / #a3a3a5 light) and is inconsistent with every other var(--muted-foreground) usage in the codebase, all of which omit the fallback since syncTheme() always propagates the variable to the tooltip portal.
Suggested change
| color: var(--muted-foreground, #a1a1aa) !important; | |
| color: var(--muted-foreground) !important; |
Same applies to the identical line in useComposerCore.ts.
— qwen3.7-max via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes the group-title color used in the web-shell
@completion menu so the section headers remain readable in dark theme.Instead of relying on an implicit/default color, the section header now uses the shared muted foreground theme token, which keeps the visual hierarchy while avoiding near-black text on dark backgrounds.
Why it's needed
In dark theme, the group titles in the web-shell
@menu could render with a color that was too close to the background, making section headers such as extensions and files difficult to read.Using an explicit theme variable makes the appearance consistent across themes and avoids accidental regressions from browser or inherited default colors.
Reviewer Test Plan
How to verify
@completion.Evidence (Before & After)
Before: group titles in the web-shell
@completion menu could appear too dark to read comfortably in dark theme.After: group titles use the muted foreground theme color and remain visible while preserving the intended visual hierarchy.
Tested on
Environment (optional)
Local web-shell build is currently blocked on the latest
mainby an unrelateduseStatusReportexport mismatch inDaemonStatusDialog; this PR only changes the group-title color styling.Risk & Scope
Linked Issues
N/A
中文说明
What this PR does
这个 PR 修复了 web-shell 中
@补全菜单分组标题的颜色，使这些 section header 在暗色主题下仍然清晰可读。这次改动不再依赖隐式/默认颜色，而是显式使用共享的 muted foreground 主题变量，从而在保留层级感的同时，避免暗色背景下出现接近黑色的文字。
Why it's needed
在暗色主题下，web-shell
@菜单中的分组标题颜色可能过于接近背景色，导致像 extensions、files 这样的 section header 难以辨认。改为使用显式的主题变量后，外观会在不同主题下保持一致，也能避免由于浏览器默认色或继承色导致的意外回归。
Reviewer Test Plan
How to verify
@补全。Evidence (Before & After)
Before：web-shell
@补全菜单中的分组标题在暗色主题下可能过暗，不利于阅读。After：分组标题改为使用 muted foreground 主题色，在保留视觉层级的同时能清晰显示。
Tested on
Environment (optional)
本地 web-shell build 目前会被最新
main中与本次改动无关的DaemonStatusDialog/useStatusReport导出不匹配问题阻塞；本 PR 只修改分组标题颜色样式。Risk & Scope
Linked Issues
N/A