Skip to content

fix(core): create temp dir before saving truncated shell output #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanzhenxin merged 1 commit into from
May 7, 2026
Merged

fix(core): create temp dir before saving truncated shell output #3875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/core/src/utils/truncation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ vi.mock('node:fs/promises');

describe('truncateAndSaveToFile', () => {
const mockWriteFile = vi.mocked(fs.writeFile);
const mockMkdir = vi.mocked(fs.mkdir);
const THRESHOLD = 40_000;
const TRUNCATE_LINES = 1000;

beforeEach(() => {
vi.clearAllMocks();
mockMkdir.mockResolvedValue(undefined);
});

it('should return content unchanged if below both threshold and line limit', async () => {
Expand All @@ -35,6 +37,7 @@ describe('truncateAndSaveToFile', () => {

expect(result).toEqual({ content });
expect(mockWriteFile).not.toHaveBeenCalled();
expect(mockMkdir).not.toHaveBeenCalled();
});

it('should truncate when line limit exceeded even if under character threshold', async () => {
Expand All @@ -59,6 +62,9 @@ describe('truncateAndSaveToFile', () => {
expect(result.outputFile).toBe(
path.join(projectTempDir, `${fileName}.output`),
);
expect(mockMkdir).toHaveBeenCalledWith(projectTempDir, {
recursive: true,
});

const head = Math.floor(TRUNCATE_LINES / 5);
const beginning = lines.slice(0, head);
Expand Down Expand Up @@ -133,6 +139,9 @@ describe('truncateAndSaveToFile', () => {
expect(result.outputFile).toBe(
path.join(projectTempDir, `${fileName}.output`),
);
expect(mockMkdir).toHaveBeenCalledWith(projectTempDir, {
recursive: true,
});
expect(mockWriteFile).toHaveBeenCalledWith(
path.join(projectTempDir, `${fileName}.output`),
content,
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/utils/truncation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export async function truncateAndSaveToFile(
const safeFileName = `${path.basename(fileName)}.output`;
const outputFile = path.join(projectTempDir, safeFileName);
try {
await fs.mkdir(projectTempDir, { recursive: true });
await fs.writeFile(outputFile, content);

return {
Expand Down
Loading