fix(core): create temp dir before saving truncated shell output - #3875
Merged
tanzhenxin merged 1 commit intoMay 7, 2026
Merged
Conversation
wenshao
approved these changes
May 7, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.5 via Qwen Code /review
tanzhenxin
approved these changes
May 7, 2026
tanzhenxin
left a comment
Collaborator
There was a problem hiding this comment.
Review
Clean one-line fix for #3874: mkdir { recursive: true } before writing the saved-output file, so fresh ACP sessions that hit oversized shell output before any project temp storage exists no longer end up with an untruncated payload. Tests cover both the below-threshold (mkdir not called) and truncating (mkdir called) paths, and the existing try/catch already absorbs mkdir failures via the error field — no new failure mode introduced.
Verdict
APPROVE — minimal, targeted, with appropriate test coverage.
TaimoorSiddiquiOfficial
pushed a commit
to TaimoorSiddiquiOfficial/HopCode
that referenced
this pull request
May 7, 2026
DragonnZhang
pushed a commit
that referenced
this pull request
May 8, 2026
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npx vitest run src/utils/truncation.test.ts from packages/core
npm run build
npm run typecheck
Scope / Risk
Testing Matrix
Testing matrix notes:
Linked Issues / Bugs
Fixes #3874