Skip to content

test(cli): stabilize AuthDialog ESC assertion #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanzhenxin merged 2 commits into from
Feb 3, 2026
Merged

test(cli): stabilize AuthDialog ESC assertion #1535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
395791f
test(cli): stabilize AuthDialog ESC assertion
liqiongyu Jan 18, 2026
1527c03
test(cli): wait for full auth error copy
liqiongyu Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/cli/src/ui/auth/AuthDialog.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,11 @@ describe('AuthDialog', () => {
await wait();

// Should show error message instead of calling handleAuthSelect
expect(lastFrame()).toContain(
'You must select an auth method to proceed. Press Ctrl+C again to exit.',
);
await vi.waitFor(() => {
const frame = lastFrame();
expect(frame).toContain('You must select an auth method');
expect(frame).toContain('Press Ctrl+C again to exit');
});
expect(handleAuthSelect).not.toHaveBeenCalled();
unmount();
});
Expand Down
Loading