test(cli): stabilize AuthDialog ESC assertion - #1535
Merged
Conversation
liqiongyu
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 19, 2026 03:43
liqiongyu
marked this pull request as draft
January 19, 2026 04:20
liqiongyu
force-pushed
the
test/authdialog-esc-stabilize
branch
from
January 19, 2026 04:23
880dc2e to
1527c03
Compare
Mingholy
approved these changes
Jan 21, 2026
liqiongyu
marked this pull request as ready for review
February 3, 2026 09:55
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…bilize test(cli): stabilize AuthDialog ESC assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Dive Deeper
AuthDialog renders the ESC error output asynchronously. The test could sometimes assert against a previous frame and flake. This change uses
vi.waitForto wait until the frame contains both:This PR is split out from #1531 to keep the MCP resource expansion PR focused.
Reviewer Test Plan
npx vitest packages/cli/src/ui/auth/AuthDialog.test.tsx.npx vitest packages/cli/src/ui/auth/AuthDialog.test.tsx -t "escape key".Testing Matrix
Linked issues / bugs