Skip to content

test(cli): stabilize AuthDialog ESC assertion - #1535

Merged
tanzhenxin merged 2 commits into
QwenLM:mainfrom
liqiongyu:test/authdialog-esc-stabilize
Feb 3, 2026
Merged

test(cli): stabilize AuthDialog ESC assertion#1535
tanzhenxin merged 2 commits into
QwenLM:mainfrom
liqiongyu:test/authdialog-esc-stabilize

Conversation

@liqiongyu

@liqiongyu liqiongyu commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

TLDR

  • Stabilize the AuthDialog ESC-key test by waiting for the async frame update before asserting.

Dive Deeper

AuthDialog renders the ESC error output asynchronously. The test could sometimes assert against a previous frame and flake. This change uses vi.waitFor to wait until the frame contains both:

  • "You must select an auth method"
  • "Press Ctrl+C again to exit"

This PR is split out from #1531 to keep the MCP resource expansion PR focused.

Reviewer Test Plan

  1. Run npx vitest packages/cli/src/ui/auth/AuthDialog.test.tsx.
  2. Optional: npx vitest packages/cli/src/ui/auth/AuthDialog.test.tsx -t "escape key".

Testing Matrix

🍏 🪟 🐧
npm run
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

@liqiongyu
liqiongyu marked this pull request as draft January 19, 2026 04:20
@liqiongyu
liqiongyu force-pushed the test/authdialog-esc-stabilize branch from 880dc2e to 1527c03 Compare January 19, 2026 04:23
@liqiongyu
liqiongyu marked this pull request as ready for review February 3, 2026 09:55
@tanzhenxin
tanzhenxin merged commit 10ae15c into QwenLM:main Feb 3, 2026
25 of 26 checks passed
xaelistic pushed a commit to xaelistic/qwen-code that referenced this pull request Jun 7, 2026
…bilize

test(cli): stabilize AuthDialog ESC assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants