Repository navigation
fix(live): accept monitor debug directories on Windows #11679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c3feb87
fix(live): accept monitor debug directories on Windows (#11678)
qwen-code-dev-bot 85a5c48
fix(live): keep monitor debug prune resilient and qualify Windows pri…
qwen-code-dev-bot 5b115e2
fix(live): report prune failures and document best-effort retention (…
qwen-code-dev-bot af82f29
fix(live): keep failed prunes retriable and report their reason (#11678)
qwen-code-dev-bot f6dfd22
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 674c014
fix(live): document silent ownership-scan skips, pin retries on both …
qwen-code-ci-bot bd4cec2
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 8d63793
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 565f619
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 9928cdb
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 4bc0dcc
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot b21ab62
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot d46b741
fix(live): report orphaned monitor-debug archives as unretained (#11678)
qwen-code-dev-bot eb5d331
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 876f6c2
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 36293c3
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 0331064
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot af19df9
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot 9efd426
Merge branch 'main' into autofix/issue-11678
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged — the claim is wrong for
src/memory/service.test.ts, but the correction targets the PR description's Test Plan, which this loop cannot edit (the same boundary was recorded last round on R1-2's thread: the PR body is owned by the workflow). Exact correction for whoever edits the body: dropsrc/memory/service.test.tsfrom the "now pass" list — the honest set is the four suites that actually failed assertions:src/proactive/monitor-debug-store.test.ts,src/proactive/realtime-monitor.test.ts,src/memory/config.test.ts,src/language-preferences.test.ts.The second failure class is recorded for follow-up through this round's deferred-findings queue, which survives the merge: 10
packages/qwen-livesuites fail to collect on the self-hosted Windows runners because@node-rs/jieba's native binding (@node-rs/jieba-win32-x64-msvc) does not load — reproduced on runs 34638450706 (runner -hk-4) and 34649003053 (runner -hk-3). Its real fix (a lazyJiebaimport insrc/memory/tokenize.ts, or a CI assertion that the optional binding resolved) is a separate root cause and stays out of this diff, per the finding.This also bears on R1-2's auto-close concern: with the deferral persisted, the 10 collect-failing suites stay tracked past
Fixes #11678.中文说明
确认——该声明对
src/memory/service.test.ts不成立,但更正对象是 PR 描述中的测试计划,本循环无法编辑它(上一轮已在 R1-2 的评论串记录过同一边界:PR 描述由工作流负责)。给编辑描述的人的确切更正:把src/memory/service.test.ts从「现在通过」列表中移除——诚实的集合是真正断言失败的四个套件:src/proactive/monitor-debug-store.test.ts、src/proactive/realtime-monitor.test.ts、src/memory/config.test.ts、src/language-preferences.test.ts。第二类失败已通过本轮的延后队列登记,合并后仍然存续:10 个
packages/qwen-live套件在自建 Windows runner 上无法收集,因为@node-rs/jieba的原生绑定(@node-rs/jieba-win32-x64-msvc)无法加载——已在运行 34638450706(runner -hk-4)与 34649003053(runner -hk-3)上复现。其真正的修复(把src/memory/tokenize.ts的Jieba导入改为惰性,或加一个断言可选绑定已解析的 CI 步骤)属于另一个根因,按该发现的要求留在本 diff 之外。这也关系到 R1-2 的自动关闭问题:延后登记持久化后,这 10 个无法收集的套件在
Fixes #11678合并后仍会被跟踪。