-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(live): accept monitor debug directories on Windows #11679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c3feb87
85a5c48
5b115e2
af82f29
f6dfd22
674c014
bd4cec2
8d63793
565f619
9928cdb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -129,9 +129,6 @@ describe('persistMemoryPreferences', () => { | |
| retrieve: { useVector: false }, | ||
| }); | ||
| expect(resolved.updater.model).toBe('custom-memory-model'); | ||
|
qwen-code-dev-bot marked this conversation as resolved.
|
||
| if (process.platform !== 'win32') { | ||
| expect(statSync(configPath).mode & 0o777).toBe(0o600); | ||
| } | ||
| expect(readdirSync(dataDir)).toEqual(['config.json']); | ||
| }); | ||
|
|
||
|
|
@@ -177,12 +174,24 @@ describe('persistMemoryPreferences', () => { | |
| }); | ||
| expect(saved.memory.observer).not.toHaveProperty('model'); | ||
| expect(resolved.observer.model).toBe('custom-memory-model'); | ||
| if (process.platform !== 'win32') { | ||
| expect(statSync(configPath).mode & 0o777).toBe(0o600); | ||
| } | ||
| expect(readdirSync(dataDir)).toEqual(['config.json']); | ||
| }); | ||
|
|
||
| // Windows has no POSIX permission bits, so skip (reportedly) rather than | ||
| // passing a test that asserted nothing. | ||
| it.skipIf(process.platform === 'win32')( | ||
| 'writes the memory config with 0600 permissions', | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] R2-1: The Test Plan's verification route says that on Windows "the previously failing suites A maintainer follows the Test Plan's own stated route ("or by reviewing the CI result of this PR's merge queue run") and sees Witness: Correct the claim rather than the code: drop One existing fact this fix must not violate: 中文说明测试计划的验证路径写道:在 Windows 上「此前失败的 失败场景。 维护者按测试计划自己给出的路径去验证(「或通过审查本 PR 合并队列运行的 CI 结果」),会看到 建议修复。 更正声明而不是更正代码:把 修复不得违反的既有事实: — qwen3.8-max via Qwen Code /review (v0.23.3)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Acknowledged — the claim is wrong for The second failure class is recorded for follow-up through this round's deferred-findings queue, which survives the merge: 10 This also bears on R1-2's auto-close concern: with the deferral persisted, the 10 collect-failing suites stay tracked past 中文说明确认——该声明对 第二类失败已通过本轮的延后队列登记,合并后仍然存续:10 个 这也关系到 R1-2 的自动关闭问题:延后登记持久化后,这 10 个无法收集的套件在 |
||
| () => { | ||
| const plain = fixture(); | ||
| persistMemoryPreferences(plain.dataDir, { enabled: false }); | ||
| expect(statSync(plain.configPath).mode & 0o777).toBe(0o600); | ||
| const bom = fixture(); | ||
| writeFileSync(bom.configPath, `\uFEFF${JSON.stringify(bom.raw)}`); | ||
| persistMemoryPreferences(bom.dataDir, { enabled: false }); | ||
| expect(statSync(bom.configPath).mode & 0o777).toBe(0o600); | ||
| }, | ||
| ); | ||
|
|
||
| it('leaves the original file untouched and cleans its temporary file when replacement fails', () => { | ||
| const { dataDir, configPath } = fixture(); | ||
| const before = readFileSync(configPath, 'utf8'); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.