Repository navigation
docs(core): say why the Todo dependency semantics are not behind the flag #11078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both cases confirmed, and the fix went the other way: rather than extend the enumeration, 2d6d780 drops the claim that produced the gap.
The block no longer bills itself as the exact blast radius, and the pointer to it ("see the preservation merge below for the exact blast radius") is gone with the block above. What is left states necessary conditions only:
That survives (1) — the cycle fallback discarding the stamped list means the three conditions are not sufficient, which "only fires when" never asserted. The fallback also keeps its own seven-line explanation fifteen lines below, in the same branch and visible in the same screenful, so restating it here would have been the third copy of the same fact.
I did not take the suggested wording because the whole point of this revision was length: the PR owner asked for the comments to be cut, and the two blocks went 25 lines → 8. Adding the two clauses back would put most of that back.
(2) is not a claim this comment makes — it is a real hazard about what the reply shows the model, not about when preservation fires. It is worth fixing, but echoing the preserved entries in the no-op reply is a behaviour change with a test to add (
preservation ∩ no-op, which as you note nothing covers), so it does not belong in a comment-only PR. Noted in Risk & Scope as out of scope; happy to open the follow-up.中文说明
两种情形都确认成立,修法反过来:2d6d780 没有去扩充枚举,而是撤掉了产生这个缺口的断言本身。
这段注释不再自称 "exact blast radius",上方指向它的那句("see the preservation merge below for the exact blast radius")也随上一段一起删掉了。剩下的只陈述必要条件(见上方代码块)。
这样就绕开了(1):环回退会丢弃被盖章的列表,说明三个条件并不充分,而 "only fires when" 从未断言充分性。而且环回退在下方十五行处保有它自己的七行解释,处于同一分支、同一屏内,在这里再复述一遍就是同一事实的第三份副本。
我没有采用建议的措辞,因为这次修订的全部目的就是长度:PR owner 要求精简注释,两段从 25 行减到 8 行,把那两个从句加回去会把削减掉的大部分又装回去。
(2)不是这段注释所作的断言——它是关于回复向模型展示了什么的真实隐患,而不是关于保留何时触发。它值得修,但在 no-op 回复中回显被保留的条目属于行为变更,还需要新增测试(你指出无人覆盖的
保留 ∩ no-op形态),因此不属于一个纯注释 PR。已在 Risk & Scope 中标注为范围之外;需要的话我来开这个后续 PR。