Skip to content

docs(core): say why the Todo dependency semantics are not behind the flag #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiliang114 merged 3 commits into from
Sep 5, 2026
+8 −0
Merged

docs(core): say why the Todo dependency semantics are not behind the flag #11078

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ccb332
docs(core): say why the Todo dependency semantics are not behind the …
Sep 5, 2026
2d6d780
docs(core): trim the Todo dependency gating comments
yiliang114 Sep 5, 2026
abaeb08
Merge remote-tracking branch 'origin/main' into m-11078
Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/src/tools/todoWrite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,11 @@ class TodoWriteToolInvocation extends BaseToolInvocation<
const previousPlan = await readTodoPlanFromFile(sessionId);
const oldTodos = previousPlan.todos;
const oldTodosMap = new Map(oldTodos.map((todo) => [todo.id, todo]));
// Not gated on `isSessionWorkflowEnabled()` on purpose, and neither is
// the `blockedBy` schema description: dependencies are plan data-model
// semantics, not presentation. Gating them on a visualization switch
// would make the same `todo_write` call store a different plan
// depending on whether anyone is looking at the graph.
const hasActivePlan = oldTodos.some(
(todo) => todo.status !== 'completed',
);
Expand All @@ -317,6 +322,9 @@ class TodoWriteToolInvocation extends BaseToolInvocation<
const data = JSON.parse(modified_content) as Record<string, unknown>;
candidateTodos = data['todos'];
} else {
// Preservation only fires when the previous plan still has an
// unfinished item and the same id carried a non-empty `blockedBy`
// that this call omits; `[]` is not nullish, so it still clears.
let preservedAnyBlockedBy = false;
candidateTodos = todos.map((todo) => {
// Preserved edges may only reference ids that survive this update:
Expand Down
Loading