-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(web-shell): visualize and manage dynamic workflow runs #10412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
9bab3c3
feat(serve): expose workflow tasks and controls
qqqys 75f2975
Merge upstream/main into codex/issue-9033-workflow-daemon-api
qqqys 80f94d6
Merge upstream/main into codex/issue-9033-workflow-daemon-api
qqqys 0187849
feat(web-shell): visualize workflow runs
qqqys bea0746
fix(serve): align workflow capability gating
qqqys 6febdb2
fix(cli): reject live workflow history deletion
qqqys fefccfb
Merge remote-tracking branch 'origin/codex/issue-9033-workflow-daemon…
qqqys 5774f61
fix(web-shell): harden workflow history UX
qqqys fdadec7
fix(serve): start controlled workflows in background
qqqys 95e8df7
Merge remote-tracking branch 'origin/codex/issue-9033-workflow-daemon…
qqqys 135bf45
fix(serve): address workflow control review blockers
qqqys 4ab652a
fix(serve): make workflow history deletion race-safe
qqqys e139338
chore(serve): resolve merge conflicts with main
qqqys 3497d0d
fix(serve): enforce workspace trust on the daemon Workflow surfaces (…
32d8934
Merge branch 'main' into codex/issue-9033-workflow-daemon-api
qwen-code-dev-bot c82ade0
merge: prepare final Workflow Web Shell demo
qqqys 52206ee
feat(web-shell): add workflow creation entry
qqqys ad9bf4e
style(web-shell): flatten the workflow execution graph
f6b1830
Merge remote-tracking branch 'origin/codex/issue-8941-workflow-web-sh…
750029e
feat(web-shell): open a saved workflow's definition from the Saved tab
c25a5f9
fix(serve): close cross-session workflow deletion races and untrusted…
qwen-code-dev-bot 2ac1f68
Merge branch 'main' into codex/issue-9033-workflow-daemon-api
qqqys 15847f9
Merge branch 'main' into codex/issue-9033-workflow-daemon-api
qqqys ed400eb
Merge branch 'main' into codex/issue-8941-workflow-web-shell
wenshao e80f785
Merge remote-tracking branch 'upstream/main' into tmp-sync-9546
qqqys eeca4d7
Merge upstream/main into codex/issue-9033-workflow-daemon-api
qqqys f8506d3
fix(serve): enforce workflow trust gates
qqqys b799ea6
fix(cli): close the four cross-session workflow-history consistency h…
qqqys 3d6b3bc
Merge remote-tracking branch 'upstream/main' into HEAD
qqqys f42b285
fix(core): drop the duplicated telemetry-swap mock property
qqqys 0b5d23c
fix(workflows): guard pending run lifecycle
qqqys 6c79490
fix(workflows): let a starting run be cancelled, and stop two slow leaks
qqqys f119607
fix(core): close the round-5 review findings on workflow task controls
qqqys c58b3fd
Merge remote-tracking branch 'upstream/main' into codex/issue-9033-wo…
qqqys 2c2c232
Merge branch 'main' into codex/issue-9033-workflow-daemon-api
qqqys 4b441a9
Merge branch 'main' into codex/issue-9033-workflow-daemon-api
qqqys 8bdd956
fix(serve): keep workflow retry and the workflowsEnabled flag consist…
qqqys 4183ee7
fix(serve): refuse to report a workflow history deletion whose regist…
qqqys 6bd83e7
Merge remote-tracking branch 'upstream/main' into codex/issue-9033-wo…
qqqys 8a7a63f
Merge branch 'feat/workflow-daemon-api' into feat/workflow-web-shell
qqqys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] R1-26: The bridge-level happy path of
getSessionSavedWorkflow— forwarding{ name }as the ext-method params — is untested; only theSessionNotFoundErrorrejection is covered (unlike the siblingincludeWorkflowsparam, which got an assertion). A regression renaming the forwarded key ships green (measured:{workflowName}mutation → 804/804); the child would then reject every read with "Invalid or missing name" and the Runs page would show every saved definition as unreadable.Witness:
Extend the extMethodCalls-asserting bridge test: attach a session, call
getSessionSavedWorkflow(id, 'deep-review'), assert the recorded params are{sessionId, name:'deep-review'}— red the moment the name stops reaching the child asname.中文说明
getSessionSavedWorkflow 的桥接层正常路径(转发 {name})没有测试:把键名改错的回归全绿(已实测),子进程会拒绝所有读取,Runs 页全部显示定义不可读。请在 extMethodCalls 断言中补充该参数检查。— glm-5.3 via Qwen Code /review (v0.22.2)