Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to switch out logging library #288

Open
atruskie opened this issue Feb 9, 2020 · 0 comments
Open

Need to switch out logging library #288

atruskie opened this issue Feb 9, 2020 · 0 comments

Comments

@atruskie
Copy link
Member

atruskie commented Feb 9, 2020

Log4Net only supports .NET Standard 1.3.

Using it in current .NET Core package results in NU1605 errors.

I've added <NoWarn>$(NoWarn);NU1605</NoWarn> to the Acoustics.Shared csproj to turn the error off for now, but it could very well result in a runtime exception later down the line.

atruskie added a commit that referenced this issue Feb 9, 2020
Known bugs:
- short file name bug (se main entry)
- #289
- #288
- ImageSharp has bugs that crash with versions greater than  1.0.0-unstable0598
- ImageSharp has bug in parallel implementation so you'll find Drawing.NoParallelConfiguration sprinkled everywhere
- And another ImageSharp bug prevents us from writing text on concatenated images

All up though, the majority of things work. Yay!
atruskie added a commit that referenced this issue Feb 17, 2020
Known bugs:
- short file name bug (se main entry)
- #289
- #288
- ImageSharp has bugs that crash with versions greater than  1.0.0-unstable0598
- ImageSharp has bug in parallel implementation so you'll find Drawing.NoParallelConfiguration sprinkled everywhere
- And another ImageSharp bug prevents us from writing text on concatenated images

All up though, the majority of things work. Yay!

Work done for #158 and #159
atruskie added a commit that referenced this issue Feb 17, 2020
Known bugs:
- short file name bug (se main entry)
- #289
- #288
- ImageSharp has bugs that crash with versions greater than  1.0.0-unstable0598
- ImageSharp has bug in parallel implementation so you'll find Drawing.NoParallelConfiguration sprinkled everywhere
- And another ImageSharp bug prevents us from writing text on concatenated images

All up though, the majority of things work. Yay!

Work done for #158 and #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant