Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Intention] Remove dependence on System.Drawing #158

Closed
atruskie opened this issue Mar 23, 2018 · 1 comment
Closed

[Intention] Remove dependence on System.Drawing #158

atruskie opened this issue Mar 23, 2018 · 1 comment
Labels
enhancement
Milestone
Move to dotnet core

Comments

@atruskie
Copy link
Member

atruskie commented Mar 23, 2018 •
edited
Loading

Expected behaviour

Image rendering should be properly supported on all platforms, and A generic GDI+ error has occurred should be an error message we never see again.

Actual behaviour

Image rendering relies on a Mono shim of System.Drawing, and we regularly see generic GDI+ errors which hamstring the way we render large images. System.Drawing is also innately unparallelizable.

Any other details

The ImageSharp project looks like a good replacement.

This is an extremely low priority issue that will involve a ton of work.

http://photosauce.net/blog/post/5-reasons-you-should-stop-using-systemdrawing-from-aspnet
@atruskie atruskie added this to the Move to dotnet core milestone Mar 23, 2018
@atruskie atruskie mentioned this issue Jul 4, 2018
Open
@cofiem cofiem mentioned this issue Jul 24, 2018
Closed
11 tasks
@atruskie atruskie mentioned this issue Nov 6, 2018
Open
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
Fixing .NET Core incompatibilities
839d5ac 
And also migrating to using ImageSharp as drawing library.

Work done for #159 and #158
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
Converting to .NET Core and ImageSharp
97dd853 
Finished fixing build errors for dotnet core conversion

Also addressed some code style issues

Work done for #158 and #159
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
.NET Core and ImageSharp: fixing unit tests
eddb7d4 
Removed some code not needed now we're on dotnet core.

Also added more tests to ensure expected resources and build tasks work as expected.

Still need to fix assembly versioning.

Work done for #158 and #159
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
Almost completes port to .NET Core
d06b7a5 
Known bugs:
- short file name bug (se main entry)
- #289
- #288
- ImageSharp has bugs that crash with versions greater than  1.0.0-unstable0598
- ImageSharp has bug in parallel implementation so you'll find Drawing.NoParallelConfiguration sprinkled everywhere
- And another ImageSharp bug prevents us from writing text on concatenated images

All up though, the majority of things work. Yay!

Work done for #158 and #159
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
Fixing .NET Core incompatibilities
a4d25e9 
And also migrating to using ImageSharp as drawing library.

Work done for #159 and #158
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
Converting to .NET Core and ImageSharp
fee81bd 
Finished fixing build errors for dotnet core conversion

Also addressed some code style issues

Work done for #158 and #159
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
.NET Core and ImageSharp: fixing unit tests
ecad1de 
Removed some code not needed now we're on dotnet core.

Also added more tests to ensure expected resources and build tasks work as expected.

Still need to fix assembly versioning.

Work done for #158 and #159
atruskie added a commit that referenced this issue Feb 17, 2020
@atruskie
Almost completes port to .NET Core
63e6299 
Known bugs:
- short file name bug (se main entry)
- #289
- #288
- ImageSharp has bugs that crash with versions greater than  1.0.0-unstable0598
- ImageSharp has bug in parallel implementation so you'll find Drawing.NoParallelConfiguration sprinkled everywhere
- And another ImageSharp bug prevents us from writing text on concatenated images

All up though, the majority of things work. Yay!

Work done for #158 and #159
@atruskie
Copy link
Member Author

atruskie commented Apr 7, 2020

Closed (completed)

@atruskie atruskie closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Move to dotnet core
Development

No branches or pull requests
1 participant
@atruskie