Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign tooltips not rendering the outlines of glowing text in fast mode #12

Merged

Conversation

haykam821
Copy link
Contributor

Fast mode sign tooltip reading 'Hello World' in pink glowing text

}

for (var text : this.text) {
textRenderer.method_37296(text, x, y, signColor, outlineColor, matrix4f, immediate, 15728880);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For light values there's a constant for it in LightmapTextureManager, probably should use that instead.
Will do that myself.

@LambdAurora LambdAurora merged commit ae4ecd9 into Queerbric:1.17 Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants