Rebasing to hourai #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se#43) * Upgraded to bevy 0.14.0; All tests and examples passing * Made error handling in example more clear * Revert to simple unwrap * Switched to git repo for crate Git version of the crate seems to more reliably provide the steamworks SDK, which will cause strange errors at startup if not prooperly configured. Targeting the same specific tag that the version of crates.io so this shouldn't cause unecessary problems. Manual upgrades will need to be done over time. At this point I might just be willing to maintain this crate since it's so useful for publishing games on steam! * More robust CI
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v2...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Git version of the crate seems to more reliably provide the steamworks SDK, which will cause strange errors at startup if not prooperly configured. Targeting the same specific tag that the version of crates.io so this shouldn't cause unecessary problems. Manual upgrades will need to be done over time. At this point I might just be willing to maintain this crate since it's so useful for publishing games on steam!
- not required based on upstream Noxime/steamworks-rs#179
|
Finally got it to merge into my own repo 😭 I worry I might have just spammed the base repo accidentally |
|
Technically nothing is actually changing, but it does clear up the "X commits behind" popup which I don't like |
|
Hello! QueenOfSquiggles |
Hey that sounds super cool. If that's what you wanna make, go for it! Have fun. Also I'd love to see it when its done so drop a link sometime ❤️ Though I gotta say there's better ways to message me lol |
|
There is a better way to contact you, but I don't know and I can't find it. I can only look for your email on GitHub.ψ(｀∇´)ψ
…---- Replied Message ----
| From | ***@***.***> |
| Date | 10/08/2024 08:27 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [QueenOfSquiggles/bevy_steamworks] Rebasing to hourai (PR #9) |
Hello! QueenOfSquiggles
I saw your mods a long time ago, and I decided to make a mod that would add my favorite bigwigs to my childhood easter eggs, so I hope you'll agree with me doing this
Hey that sounds super cool. If that's what you wanna make, go for it! Have fun. Also I'd love to see it when its done so drop a link sometime ❤️
Though I gotta say there's better ways to message me lol
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
I've got my contact info in the footer of my website (though I should check if my github links to my website, might have forgotten to do that) |
|
I think I completely forgot about the jet lag.😂I still thought in the morning that you should be too busy to reply, but now I remember that there is still time difference.😓
…---- Replied Message ----
| From | ***@***.***> |
| Date | 10/08/2024 21:49 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [QueenOfSquiggles/bevy_steamworks] Rebasing to hourai (PR #9) |
There is a better way to contact you, but I don't know and I can't find it. I can only look for your email on GitHub.ψ(｀∇´)ψ
---- Replied Message ----
| From | @.> |
| Date | 10/08/2024 08:27 |
| To | @.> |
| Cc | @.>@.> |
| Subject | Re: [QueenOfSquiggles/bevy_steamworks] Rebasing to hourai (PR #9) |
Hello! QueenOfSquiggles
I saw your mods a long time ago, and I decided to make a mod that would add my favorite bigwigs to my childhood easter eggs, so I hope you'll agree with me doing this
Hey that sounds super cool. If that's what you wanna make, go for it! Have fun. Also I'd love to see it when its done so drop a link sometime ❤️
Though I gotta say there's better ways to message me lol
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>
I've got my contact info in the footer of my website (though I should check if my github links to my website, might have forgotten to do that)
https://queenofsquiggles.github.io/
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Do you have an account in Weibo? We can talk in Weibo. It seems that international social software is not allowed in my country.😓
…---- Replied Message ----
| From | ***@***.***> |
| Date | 10/08/2024 21:49 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [QueenOfSquiggles/bevy_steamworks] Rebasing to hourai (PR #9) |
There is a better way to contact you, but I don't know and I can't find it. I can only look for your email on GitHub.ψ(｀∇´)ψ
---- Replied Message ----
| From | @.> |
| Date | 10/08/2024 08:27 |
| To | @.> |
| Cc | @.>@.> |
| Subject | Re: [QueenOfSquiggles/bevy_steamworks] Rebasing to hourai (PR #9) |
Hello! QueenOfSquiggles
I saw your mods a long time ago, and I decided to make a mod that would add my favorite bigwigs to my childhood easter eggs, so I hope you'll agree with me doing this
Hey that sounds super cool. If that's what you wanna make, go for it! Have fun. Also I'd love to see it when its done so drop a link sometime ❤️
Though I gotta say there's better ways to message me lol
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>
I've got my contact info in the footer of my website (though I should check if my github links to my website, might have forgotten to do that)
https://queenofsquiggles.github.io/
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
I'd rather not add another social account, especially on a site that I can't really read 😭 (I can only really read English with any degree of proficiency) But I do have an email if you have to contact me for something. Either way, best of luck! |
|
Ok ~ _ ~, have a nice new day.
…---- Replied Message ----
| From | ***@***.***> |
| Date | 10/11/2024 21:16 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [QueenOfSquiggles/bevy_steamworks] Rebasing to hourai (PR #9) |
I'd rather not add another social account, especially on a site that I can't really read 😭 (I can only really read English with any degree of proficiency)
But I do have an email if you have to contact me for something. Either way, best of luck!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.