Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SingleClient #179

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Remove SingleClient #179

merged 1 commit into from
Aug 2, 2024

Conversation

msvbg
Copy link
Contributor

@msvbg msvbg commented May 11, 2024

Closes: #159

The tests do not run for me, neither on main nor on this branch. I get a bunch of timeouts like these:

test matchmaking::test_lobby has been running for over 60 seconds
test networking_sockets::tests::test_create_listen_socket_ip has been running for over 60 seconds
test networking_sockets::tests::test_socket_connection has been running for over 60 seconds
test networking_types::tests::test_allocate_and_free_message has been running for over 60 seconds
test networking_utils::tests::test_get_networking_status has been running for over 60 seconds
test remote_storage::test_cloud has been running for over 60 seconds

I am also confused about this text in the Steam docs, referenced by @james7132 in the above issue:

SteamAPI_RunCallbacks is safe to call from multiple threads simultaneously, but if you choose to do this, callback code could be executed on any thread. One alternative is to call SteamAPI_RunCallbacks from the main thread only, and call SteamAPI_ReleaseCurrentThreadMemory regularly on other threads.

If I only run run_callbacks from the main thread, why would I need to release memory on other threads? And if this is a problem, isn't it also a problem with the current bindings since there is no helper for cleaning up memory on other threads?

@ceifa
Copy link
Collaborator

ceifa commented Aug 1, 2024

Note: This is a breaking change

@Noxime Noxime merged commit fbb7963 into Noxime:master Aug 2, 2024
9 checks passed
@msvbg msvbg deleted the remove-single-client branch August 2, 2024 21:46
JonnyPower added a commit to JonnyPower/bevy_steamworks that referenced this pull request Aug 24, 2024
- not required based on upstream Noxime/steamworks-rs#179
QueenOfSquiggles pushed a commit to QueenOfSquiggles/bevy_steamworks that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SingleClient may be redundant
3 participants