override_redirect protection breaks context menus on ultrawide #6518

n0madK · 2021-04-10T12:05:51Z

Qubes OS version

Qubes 4.1

Brief summary

When I connect an ultrawide monitor to a laptop, then open a context menu in an application on the far right side of the screen, the overridde_redirect protection triggers and the context menu does not open.

To Reproduce

Steps to reproduce the behavior:

Boot laptop
Start Thunderbird
Connect ultrawide monitor
Q->System Tools->Display, disable laptop screen
Drag Thunderbird to the right-side
Right-click on an email

Expected behavior

Context menu opens.

Actual behavior

Context menu flickers and closes. The override_redirect protection popup shows.

Solutions you've tried

Restarting the VM after the screen settings have been changed allows the context menu to behave as expected

Additional context

When opening the context menu, a window opens that extends from the left edge of the screen to the place where the context menu should open, then immediately closes. I wonder if:

the application (Thunderbird) is first opening a window the full width of the current screen before resizing
the xside.c retains the original screen geometry at VM boot time (ie changing the screen size does not propagated to running VMs) - https://github.com/QubesOS/qubes-gui-daemon/pull/41/files#diff-7897f6116dd3815ad17499205f816d770805aca6ce63e96ff55be4fe2d95a3d6R1147

I'm not sure how to debug this, but I also don't see how else this bug would trigger.

Related, non-duplicate issues

QubesOS/qubes-gui-daemon#41
#4705

SaswatPadhi · 2021-04-25T09:23:31Z

After a dom0 update this bug appears on my system too. It's super annoying! Basic apps that used to work fine (like Firefox) now crash quite often.

First a popup shows up regarding override_redirect
At some point the window closes and GUI for the AppVM crashes
Only solution is to restart the AppVM and hope that I don't hit the bug again

Here's what I see in the guid.<appvm>.log:

invalid PMaxSize for 0x54001d2 (32766/32766)
invalid PMaxSize for 0x54001e3 (32766/32766)
invalid PMaxSize for 0x54001e6 (32766/32766)
This VM has attempted to create a very large window in a manner that would have prevented you from closing it and regaining the control of Qubes OS's graphical user interface.

As a protection measure, the "override_redirect" flag of the window in question has been unset. If this creates unexpected issues in the handling of this VM's windows, please set "override_redirect_protection" to "false" for this VM in /etc/qubes/guid.conf to disable this protection measure and restart the VM.

This message will only appear once per VM per session. Please click on this notification to close it.
ErrorHandler: BadAccess (attempt to access private resource denied)
                 Major opcode: 130 (MIT-SHM)
                 Minor opcode: 1 (X_ShmAttach)
                 ResourceID:   0x54001e7
                 Failed serial number:  2170
                 Current serial number: 2171
XShmAttach failed for window 0x54001e6(remote 0x800048)
ErrorHandler: BadAccess (attempt to access private resource denied)
                 Major opcode: 130 (MIT-SHM)
                 Minor opcode: 1 (X_ShmAttach)
                 ResourceID:   0x54001e0
                 Failed serial number:  2191
                 Current serial number: 2192
XShmAttach failed for window 0x54001e6(remote 0x800048)

SaswatPadhi · 2021-05-15T03:58:22Z

Also note that, the warning states:

please set "override_redirect_protection" to "false" for this VM in /etc/qubes/guid.conf to disable this protection measure

But at the top of /etc/qubes/guid.conf we see:

# EDITING THIS FILE WILL NOT HAVE ANY EFFECT! It is not read by GUI daemon
# anymore, and is left here for reference only. To configure the GUI daemon,
# use qvm-features (see 'man qvm-features' for details).

Can we:

update warning so it states the qvm-features commandline to be used?
provide a UI to flip this Qube Manager? at least globally in dom0, because we do so for allow_fullscreen etc.

andrewdavidwong · 2021-05-15T07:34:52Z

provide a UI to flip this Qube Manager? at least globally in dom0, because we do so for allow_fullscreen etc.

This should be filed as a separate issue, as it would be a separate enhancement.

na-- · 2021-06-09T06:53:40Z

This bug regularly occurs for me and messes up the NetworkManager's sys-net system tray icon, despite the fact that I should have disabled the override_redirect protection (I'm on 4.1) through qvm-features 😕

$ qvm-features sys-net gui-override-redirect-protection
false

SaswatPadhi · 2021-06-30T23:18:47Z

Same for me. This issue is making it impossible for me to use most apps, like Firefox, which show context menus / popups.

Could someone please state the exact steps to disable this?

marmarek · 2021-06-30T23:42:03Z

$ qvm-features sys-net gui-override-redirect-protection
false

String "false" actually is not a boolean negative value... An empty string is (see man qvm-features). So, it should be:

qvm-features sys-net gui-override-redirect-protection ""

But also, it should not trigger on normal usage, and I never got it for NetworkManager, Firefox or any other similar common applications. Can anyone who is affected set debug property on an affected qube to "1" (or true or similar) and then send a guid log when the issue happens?

SaswatPadhi · 2021-07-01T00:02:55Z

Yes sure, I can try to post a debug log in a bit.

Thanks a lot for the instructions as well, @marmarek!

n0madK · 2021-07-01T07:03:35Z

I can reproduce this 100% of the time with the steps in my first post.
guid.email.log

After disabling gui-override-redirect-protection and triggering the issue, the top right menu completely breaks in Thunderbird:

Start email vm
Plug in ultrawide monitor
Drag Thunderbird off the laptop screen to the right
Open the menu (nothing happens)
Drag Thunderbird back onto the laptop screen
Open the menu (nothing happens)

I have to close and re-open the Thunderbird to recover.
guid.email.log

marmarek · 2021-07-01T10:57:22Z

Thanks, that's exactly the log I needed!

handle_configure_from_vm, local 0x5e00232 remote 0x140013e, 338/605, was 200/200, ovr=1, xy 2693/146, was 0/0
force_on_screen(from handle_configure_from_vm) returns 1 (reason 3): window 0x5e00232, xy 2693 146, wh 338 605, work area 1920 1080 borderwidth 0
XMoveResizeWindow local 0x5e00232 remote 0x140013e, xy 2693 146 (vm_window is 2693 146) wh -773 605
MSG_WINDOW_DUMP for 0x5e00232(0x140013e): 338x605, type = 0
process_xevent_configure(synth 0) local 0x5e00232 remote 0x140013e, 64763/605, was -773/605, xy 2693/146 was 2693/146

Negative size! It wrapped around into absurdly large window. I guess something went wrong in QubesOS/qubes-gui-daemon#56

marmarek · 2021-07-01T11:06:08Z

work area 1920 1080

Is this accurate for your (combined) screen size? if you have external monitor connected, then likely not...
Can you check xprop -root _NET_WORKAREA in dom0?

Instead of trying to check for offscreen windows while sanitizing window positions, return early in the case of offscreen windows, and then sanitize x, y, width, height, x + width, and y + height separately. This takes more code, but the new code is much, *much* simpler and easier to understand. Fixes QubesOS/qubes-issues#6518.

n0madK · 2021-07-01T13:38:10Z

Laptop only

$ xprop -root _NET_WORKAREA
_NET_WORKAREA(CARDINAL) = 0, 39, 1920, 1041, 0, 39, 1920, 1041, 0, 39, 1920, 1041

Monitor only

$ xprop -root _NET_WORKAREA
_NET_WORKAREA(CARDINAL) = 0, 39, 5120, 1401, 0, 39, 5120, 1401, 0, 39, 5120, 1401

Laptop+monitor mirrored

$ xprop -root _NET_WORKAREA
_NET_WORKAREA(CARDINAL) = 0, 39, 5120, 1401, 0, 39, 5120, 1401, 0, 39, 5120, 1401

Instead of trying to check for offscreen windows while sanitizing window positions, return early in the case of offscreen windows, and then sanitize x, y, width, height, x + width, and y + height separately. This takes more code, but the new code is much, *much* simpler and easier to understand. Fixes QubesOS/qubes-issues#6518.

It is _NET_CURRENT_DESKTOP, not _NET_WM_CURRENT_DESKTOP. Adjust variable name too. QubesOS/qubes-issues#6518

Subscribe to root window's property change events, otherwise gui-daemon won't receive _NET_WORKAREA change events. Update it also after re-reading root window size. QubesOS/qubes-issues#6518

Instead of trying to check for offscreen windows while sanitizing window positions, return early in the case of offscreen windows, and then sanitize x, y, width, height, x + width, and y + height separately. This takes more code, but the new code is much, *much* simpler and easier to understand. Fixes QubesOS/qubes-issues#6518.

marmarek · 2021-08-26T23:14:32Z

Ok, so I'm afraid(?) this is exactly what Xfce requested to do:

_NET_WORKAREA(CARDINAL) = 0, 1229, 1920, 1051, ...

This means Xfce requested to not use area outside of 1920x1051 rectangle at (0, 1229). I'm not sure how a panel between monitors should be represented, but the way it currently is, should result in windows appearing only on the bottom screen...

SaswatPadhi · 2021-08-26T23:23:44Z

Thanks @marmarek.
I agree that this looks like an Xfce issue at this point. I could set this panel to auto hide and that works well for now.

One remaining question I have is, how does normal window placement work? As in, why are we able to place Firefox in the top monitor (either by dragging it there, or the default placement when mouse is in the monitor), but we can't place context menus there?

SaswatPadhi · 2021-08-26T23:24:29Z

Also, dom0 context menus work correctly in both monitors, it's just AppVM context menus that have this issue.

marmarek · 2021-08-26T23:28:00Z

We try to be a bit stricter how VM can place its windows, to prevent it obscuring critical UI elements. With dom0 windows, it's directly responsibility of the window manager only, and apparently it knows more accurate definition of allowed areas.
The context menus are outside of window manager control completely, and that's why we need to enforce placement rules on our own.

DemiMarie · 2021-08-27T14:33:32Z

What does xprop -root show? Is there another property that provides more information? _NET_WORKAREA doesn’t provide enough information for the GUI daemon to properly handle this situation.

qubesos-bot · 2021-09-09T02:34:45Z

Automated announcement from builder-github

The package qubes-gui-daemon_4.1.15-1+deb10u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot · 2021-09-09T02:40:52Z

Automated announcement from builder-github

The component gui-daemon (including package qubes-audio-daemon-4.1.15-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot · 2021-09-09T02:42:01Z

Automated announcement from builder-github

The component gui-daemon (including package qubes-audio-daemon-4.1.15-1.fc32) has been pushed to the r4.1 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

Marking as draft because I am not sure if the call to abort() is justified. Fixes QubesOS/qubes-issues#6518.

n0madK added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Apr 10, 2021

andrewdavidwong added C: gui-virtualization needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Apr 10, 2021

andrewdavidwong added this to the Release 4.1 milestone Apr 10, 2021

DemiMarie mentioned this issue Jul 1, 2021

force_on_screen(): fix calculations QubesOS/qubes-gui-daemon#71

Merged

marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Jul 3, 2021

Fix _NET_CURRENT_DESKTOP atom name

6a21e14

It is _NET_CURRENT_DESKTOP, not _NET_WM_CURRENT_DESKTOP. Adjust variable name too. QubesOS/qubes-issues#6518

marmarek mentioned this issue Jul 3, 2021

Fix discovering desktop work area QubesOS/qubes-gui-daemon#72

Merged

qubesos-bot added r4.1-bullseye-stable and removed r4.1-bullseye-cur-test labels Sep 9, 2021

qubesos-bot added r4.1-buster-stable and removed r4.1-buster-cur-test labels Sep 9, 2021

qubesos-bot added r4.1-dom0-stable r4.1-fc31-stable and removed r4.1-dom0-cur-test r4.1-fc31-cur-test labels Sep 9, 2021

qubesos-bot added r4.1-fc32-stable r4.1-fc33-stable and removed r4.1-fc32-cur-test r4.1-fc33-cur-test labels Sep 9, 2021

andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Sep 9, 2021

DemiMarie mentioned this issue Oct 4, 2021

Manage popup windows in the GUI daemon #6931

Open

andrewdavidwong modified the milestones: Release 4.1, Release 4.1 updates Feb 5, 2022

DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Aug 2, 2022

Draft: Consider work area when positioning windows

7c883fa

Marking as draft because I am not sure if the call to abort() is justified. Fixes QubesOS/qubes-issues#6518.

DemiMarie mentioned this issue Aug 2, 2022

Draft: Consider work area when positioning windows QubesOS/qubes-gui-daemon#113

Closed

DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Oct 3, 2022

Draft: Consider work area when positioning windows

1bd50b6

Marking as draft because I am not sure if the call to abort() is justified. Fixes QubesOS/qubes-issues#6518.

andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023

andrewdavidwong removed this from the Release 4.1 updates milestone Aug 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

override_redirect protection breaks context menus on ultrawide #6518

override_redirect protection breaks context menus on ultrawide #6518

n0madK commented Apr 10, 2021

SaswatPadhi commented Apr 25, 2021

SaswatPadhi commented May 15, 2021

andrewdavidwong commented May 15, 2021

na-- commented Jun 9, 2021

SaswatPadhi commented Jun 30, 2021

marmarek commented Jun 30, 2021

SaswatPadhi commented Jul 1, 2021

n0madK commented Jul 1, 2021

marmarek commented Jul 1, 2021

marmarek commented Jul 1, 2021

n0madK commented Jul 1, 2021

marmarek commented Aug 26, 2021 •

edited

Loading

SaswatPadhi commented Aug 26, 2021 •

edited

Loading

SaswatPadhi commented Aug 26, 2021

marmarek commented Aug 26, 2021 •

edited

Loading

DemiMarie commented Aug 27, 2021

qubesos-bot commented Sep 9, 2021

qubesos-bot commented Sep 9, 2021

qubesos-bot commented Sep 9, 2021

override_redirect protection breaks context menus on ultrawide #6518

override_redirect protection breaks context menus on ultrawide #6518

Comments

n0madK commented Apr 10, 2021

SaswatPadhi commented Apr 25, 2021

SaswatPadhi commented May 15, 2021

andrewdavidwong commented May 15, 2021

na-- commented Jun 9, 2021

SaswatPadhi commented Jun 30, 2021

marmarek commented Jun 30, 2021

SaswatPadhi commented Jul 1, 2021

n0madK commented Jul 1, 2021

marmarek commented Jul 1, 2021

marmarek commented Jul 1, 2021

n0madK commented Jul 1, 2021

marmarek commented Aug 26, 2021 • edited Loading

SaswatPadhi commented Aug 26, 2021 • edited Loading

SaswatPadhi commented Aug 26, 2021

marmarek commented Aug 26, 2021 • edited Loading

DemiMarie commented Aug 27, 2021

qubesos-bot commented Sep 9, 2021

qubesos-bot commented Sep 9, 2021

qubesos-bot commented Sep 9, 2021

marmarek commented Aug 26, 2021 •

edited

Loading

SaswatPadhi commented Aug 26, 2021 •

edited

Loading

marmarek commented Aug 26, 2021 •

edited

Loading