Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage popup windows in the GUI daemon #6931

Open
DemiMarie opened this issue Oct 4, 2021 · 0 comments
Open

Manage popup windows in the GUI daemon #6931

DemiMarie opened this issue Oct 4, 2021 · 0 comments
Labels
C: gui-virtualization fixed-by-wayland Bugs that would not appear if Qubes OS used Wayland instead of X11 P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@DemiMarie
Copy link

How to file a helpful issue

The problem you're addressing (if any)

Currently, popup windows are override redirect and not managed at all. This has lead to security vulnerabilities and other general badness.

The solution you'd like

Wayland has a much cleaner solution: the application provides the compositor with both the popup window itself, and with the constraints the compositor should use while placing it. Qubes OS should use this approach.

The value to a user, and who that user might be

Eliminating override-redirect windows will eradicate an entire class of bugs in the GUI daemon. It would prevent recurrences of QSB#072, and fix #4705, #6822, #5499, and #6518. It would also make fixing #6347 and #6256 much easier.
@DemiMarie DemiMarie added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Oct 4, 2021
@andrewdavidwong andrewdavidwong added this to the Release TBD milestone Oct 4, 2021
@ninavizz ninavizz mentioned this issue Oct 24, 2021
Open
@andrewdavidwong andrewdavidwong removed this from the Release TBD milestone Aug 13, 2023
@DemiMarie DemiMarie added the fixed-by-wayland Bugs that would not appear if Qubes OS used Wayland instead of X11 label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: gui-virtualization fixed-by-wayland Bugs that would not appear if Qubes OS used Wayland instead of X11 P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DemiMarie @andrewdavidwong