Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab beta 0 #119

Merged
merged 14 commits into from
Apr 25, 2023

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou marked this pull request as draft March 28, 2023 10:13
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/update_latest_jlab_collab

@hbcarlos
Copy link
Contributor

Hey @martinRenou! Can I commit here?

I would like to continue this PR to update to jupyter_collaboration alpha.7 and lab beta.0.

@hbcarlos hbcarlos self-assigned this Mar 29, 2023
@hbcarlos hbcarlos marked this pull request as ready for review March 29, 2023 10:59
@martinRenou martinRenou mentioned this pull request Apr 3, 2023
@hbcarlos hbcarlos marked this pull request as draft April 17, 2023 13:23
@trungleduc trungleduc force-pushed the update_latest_jlab_collab branch 2 times, most recently from 8665e2f to 88d2765 Compare April 25, 2023 13:55
@trungleduc trungleduc marked this pull request as ready for review April 25, 2023 15:02
@trungleduc
Copy link
Member

The two failed tests are just because of the pixel-alignment issue.

Sketcher-Circle-example-2D-FCStd-diff
Sketcher-Display-example-2D-FCStd-diff

I propose we move on with this PR and update the 2 snapshots later with the galata bot.

@martinRenou
Copy link
Member Author

martinRenou commented Apr 25, 2023

Sounds good to me! I cannot review my own PR with the Github buttons. Feel free to approve it yourself and merge! Actually I could merge, Thanks!

@martinRenou martinRenou merged commit e17750b into jupytercad:main Apr 25, 2023
@martinRenou martinRenou deleted the update_latest_jlab_collab branch April 25, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants