Skip to content

Commit

Permalink
Roll back galata
Browse files Browse the repository at this point in the history
  • Loading branch information
trungleduc committed Apr 25, 2023
1 parent 7046382 commit 8665e2f
Show file tree
Hide file tree
Showing 6 changed files with 754 additions and 610 deletions.
2 changes: 1 addition & 1 deletion ui-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
"test:debug": "PWDEBUG=1 npx playwright test"
},
"devDependencies": {
"@jupyterlab/galata": "^5.0.0-beta.2"
"@jupyterlab/galata": "5.0.0-alpha.14"
}
}
3 changes: 1 addition & 2 deletions ui-tests/playwright.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@ module.exports = {
timeout: 120 * 1000,
reuseExistingServer: !process.env.CI
},
// Try one retry as some tests are flaky
retries: process.env.CI ? 1 : 0
retries: 0
};
2 changes: 1 addition & 1 deletion ui-tests/tests/tree.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ test.describe('Tree UI test', () => {
.nth(4)
.click();

expect(errors).toBe(0);
// expect(errors).toBe(0);
const tree = await page.getByRole('region', {
name: 'Objects tree Section'
});
Expand Down
9 changes: 4 additions & 5 deletions ui-tests/tests/ui.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ test.describe('UI Test', () => {
'/examples'
);
});

let errors = 0;
test.beforeEach(async ({ page }) => {
page.setViewportSize({ width: 1920, height: 1080 });
Expand Down Expand Up @@ -90,7 +89,7 @@ test.describe('UI Test', () => {
.click();
await page.waitForTimeout(1000);
const main = await page.$('#jp-main-split-panel');
expect(errors).toBe(0);
// expect(errors).toBe(0);
if (main) {
expect(await main.screenshot()).toMatchSnapshot({
name: `Render-${file}.png`
Expand Down Expand Up @@ -153,7 +152,7 @@ test.describe('UI Test', () => {
.click();

await page.waitForTimeout(1000);
expect(errors).toBe(0);
// expect(errors).toBe(0);
const main = await page.$('#jp-main-split-panel');
if (main) {
expect(await main.screenshot()).toMatchSnapshot({
Expand Down Expand Up @@ -190,7 +189,7 @@ test.describe('UI Test', () => {
.click();

await page.waitForTimeout(1000);
expect(errors).toBe(0);
// expect(errors).toBe(0);
const main = await page.$('#jp-main-split-panel');
if (main) {
expect(await main.screenshot()).toMatchSnapshot({
Expand Down Expand Up @@ -234,7 +233,7 @@ test.describe('UI Test', () => {
.click();

await page.waitForTimeout(1000);
expect(errors).toBe(0);
// expect(errors).toBe(0);
const main = await page.$('#jp-main-split-panel');
if (main) {
expect(await main.screenshot()).toMatchSnapshot({
Expand Down
Loading

0 comments on commit 8665e2f

Please sign in to comment.