Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JLab remix #120

Closed
wants to merge 23 commits into from
Closed

JLab remix #120

wants to merge 23 commits into from

Conversation

martinRenou
Copy link
Member

This builds upon #119

It's still very much in progress

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/app

@martinRenou
Copy link
Member Author

@jtpio I'm opening this early to get some feedback from you on the approach.

I'm struggling to make a custom MainMenu in https://github.com/QuantStack/jupytercad/pull/120/files#diff-1f52c6c256b9d1ac999449f7408fa02a5d78de5489933d5c1a87326840225445
My previous versions that were not building upon JupyterLab 4 beta were working with the old way of making menus, but now my menu does not work anymore. It does not show up in the resulting app and I'm out of ideas. I could really use your eyes on this!

@jtpio
Copy link
Contributor

jtpio commented Apr 4, 2023

Thanks @martinRenou I'll have a look. It's possible there could an issue / breaking change in lab 4.

That reminds me of an issue related to Menus when updating Notebook to a lab pre-release: jupyter/notebook#6757 (comment). Although it does not look the same issue exactly.

@trungleduc trungleduc mentioned this pull request Apr 27, 2023
@martinRenou
Copy link
Member Author

Closing as replaced by Trung's PR

@martinRenou martinRenou closed this May 2, 2023
@martinRenou martinRenou deleted the app branch May 2, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants