[supply_demand_heterogeneity] Translation Update #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, everyone! I have updated the translation of supply_demand_heterogeneity, please have a look and give me some suggestions. Thank you!
✅ Deploy Preview for playful-platypus-17d3bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmcky
reviewed
Mar 13, 2025
Contributor
mmcky
left a comment
mmcky
left a comment
There was a problem hiding this comment.
thanks @XYshi725 for these updates.
I have just left some comments re: cause of execution failures.
@HumphreyYang I wil leave the translation review to you. Thank you.
| 求得 $\mu_i, 其中 i = 1,2$。 | ||
| ```{exercise-start} | ||
| ```{练习-start} |
Contributor
There was a problem hiding this comment.
Suggested change
| ```{练习-start} | |
| ```{exercise-start} |
Contributor
There was a problem hiding this comment.
admonition names will need to be in English for them to work with Jupyter-book build software.
| $$ | ||
| ```{exercise-end} | ||
| ```{练习-end} |
Contributor
There was a problem hiding this comment.
Suggested change
| ```{练习-end} | |
| ```{exercise-end} |
Contributor
Author
|
OK, I will fix that later. Thank you!
…---Original---
From: "Matt ***@***.***>
Date: Thu, Mar 13, 2025 11:41 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [QuantEcon/lecture-intro.zh-cn] [supply_demand_heterogeneity]Translation Update (PR #173)
@mmcky commented on this pull request.
thanks @XYshi725 for these updates.
I have just left some comments re: cause of execution failures.
@HumphreyYang I wil leave the translation review to you. Thank you.
In lectures/supply_demand_heterogeneity.md:
> -```{exercise-start} +```{练习-start} ⬇️ Suggested change -```{练习-start} +```{exercise-start}
In lectures/supply_demand_heterogeneity.md:
> @@ -98,68 +98,68 @@ $$ e = e_1 + e_2 . $$ -```{exercise-end} +```{练习-end} ⬇️ Suggested change -```{练习-end} +```{exercise-end}
In lectures/supply_demand_heterogeneity.md:
> -```{exercise-start} +```{练习-start}
admonition names will need to be in English for them to work with Jupyter-book build software.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
Hi @XYshi725, Many thanks for the detialed review! Let's use 餍足点 which is consistent with baidu baike, but admittedly these all sound weird to me : ) I will update them in the lecture! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, everyone! I have updated the translation of supply_demand_heterogeneity, please have a look and give me some suggestions. Thank you!
Besides, when I was translating this lecture, I found that I mistakenly translated bliss point to 最优满足点 in the lecture supply_demand_multiple_goods. However it seems that 极乐点 is a more common expression in Chinese.
How to fix that?