Skip to content

Conversation

@camdecoster
Copy link
Contributor

@camdecoster camdecoster commented Aug 29, 2025

Description

Make regex patterns case insensitive and transform keyword string to lowercase before running check.

Closes #80.

Changes

  • Make regex patterns case insensitive (except keyword pattern)
  • Transform keyword string to lowercase before running check
  • Add tests for uppercase letters

Testing

  • Be on master
  • Call the library with named color with uppercase letters: cs.get("BLUE")
  • Note that a null value is returned
  • Switch to this branch
  • Call the library with named color with uppercase letters: cs.get("BLUE")
  • Note that an array of numbers is returned representing the named color

Notes

@Qix-
Copy link
Owner

Qix- commented Aug 29, 2025

@Qix- Qix- closed this Aug 29, 2025
@Qix- Qix- reopened this Sep 2, 2025
@Qix-
Copy link
Owner

Qix- commented Sep 2, 2025

This can just be a /i on the regexes I believe, and then a single .toLowerCase() for the keywords.

@camdecoster camdecoster changed the title feat: Normalize string before checking it feat: Make string checks case insensitive Sep 2, 2025
@camdecoster
Copy link
Contributor Author

@Qix- any chance you could review this and #78 in the next week?

@camdecoster
Copy link
Contributor Author

@Qix- hello! I know you've had a busy time lately. Hopefully things have calmed down. Do you have time to take a look at this PR and #81 next week? Alternatively, I'm happy to step in as a maintainer if that would be helpful.

@Qix-
Copy link
Owner

Qix- commented Oct 17, 2025

Can you rebase? :)

@camdecoster
Copy link
Contributor Author

I resolved the conflicts. Let me know if you need anything else.

@camdecoster
Copy link
Contributor Author

@Qix- hello! Do you have time to review this PR next week?

@LitoMore
Copy link
Collaborator

LitoMore commented Nov 8, 2025

I will take a look.

@Qix- Qix- merged commit dedbb42 into Qix-:master Nov 15, 2025
3 checks passed
@Qix-
Copy link
Owner

Qix- commented Nov 15, 2025

Thanks! Sorry for the delay. Published as 2.1.4.

@camdecoster
Copy link
Contributor Author

Awesome! Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Named colors with uppercase letters aren't recognized

3 participants