Named colors with uppercase letters aren't recognized

[camdecoster]

Description

Named colors with uppercase letters aren't recognized by the library.

Steps to reproduce

• Load the library (using Codepen, a project, etc.): import cs from "color-string"
• Call the library with a named color with an uppercase letter: cs.get("Blue")
• Note that a null value is returned

Notes

• Though these named colors are supposed to be lowercase by spec, it seems reasonable (and user friendly) to handle uppercase letters as well
• A call to toLowerCase for all methods where a string is passed in should take care of it

[Qix-]

No thank you :) This makes all lookups have extra processing, where we try to be as per-spec as possible.

[camdecoster]

Would you accept a call to toLowerCase in color instead of color-string?

[Qix-]

Ehh, not really. I haven't heard this being a real problem many are facing, and it adds a lot of string processing overhead in cases where color[-string] are used in tight loops.

Is there a particular issue you hit that prompted this change?

[camdecoster]

I'm transitioning from the TinyColor library in plotly.js and it handled situations like this. I was hoping not to have to refactor to handle colors with uppercase letters, but I might just skip it and say people have to use a valid string.

[Qix-]

I mean yeah, I think (philosophically) boxing people into using correct inputs to begin with is a much healthier way of going about things. Unfortunately javascript (and typescript for that matter) lacks the sort of constraints needed to really make it simpler to enforce.

The end result of allowing anything is that 1) purely invalid inputs still return null, and 2) now everyone in the "happy path" who does standardize on valid inputs pays another small, but measurable, performance hit. I know that the color family is used in tight loops across various downstream dependents that do image processing and I'd rather not affect them if I can help it.

[camdecoster]

That's totally understandable. I'm trying to make my inconvenience somebody else's, which isn't very fair. Just get your string right and all will be well.

[camdecoster]

@Qix- it turns out that the named colors are supposed to be case insensitive.

As usual for CSS-defined <ident>s, all of these keywords are ASCII case-insensitive.

To meet spec, I think the call to toLowerCase will be necessary.

[Qix-]

Ah yeah I must have misread that last time I looked. Welp, there we go.