Deprecate circuit-library Jupyter magic#9940
Merged
mtreinish merged 3 commits intoQiskit:mainfrom May 12, 2023
Merged
Conversation
This has not been used since the switch away from using `jupyter-execute` in Qiskitgh-9346, so is neither maintained nor necessary. Any improvements to styling should be made to the new paths, not to these. These objects were originally intended only for the documentation so we expect user impact to be minimal, and the objects are not maintained anyway.
jakelishman
added
the
Changelog: Deprecated
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Member
Author
|
Oh yeah, I forgot about the freeze - I've put the wrong version in all the On another note: I checked Paul's blog (expecting that to be the most likely place the magic might still be used), and it's not there. |
Pull Request Test Coverage Report for Build 4669473687
💛 - Coveralls |
garrison
approved these changes
May 12, 2023
mtreinish
approved these changes
May 12, 2023
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Deprecate circuit-library Jupyter magic This has not been used since the switch away from using `jupyter-execute` in Qiskitgh-9346, so is neither maintained nor necessary. Any improvements to styling should be made to the new paths, not to these. These objects were originally intended only for the documentation so we expect user impact to be minimal, and the objects are not maintained anyway. * Correct versions for deprecation * Add missing import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This has not been used since the switch away from using
jupyter-executein gh-9346, so is neither maintained nor necessary. Any improvements to styling should be made to the new paths, not to these. These objects were originally intended only for the documentation so we expect user impact to be minimal, and the objects are not maintained anyway.Details and comments
These are the only direct users of the Pygments lexer that caused us problems that needed a fix in #9938. We planned to deprecate these in #9346 (comment), but we failed to follow up on it at the time.