Pin pygments in CI#9938
Merged
jakelishman merged 1 commit intoQiskit:mainfrom Apr 11, 2023
Merged
Conversation
The recent release of pygments 2.15.0 [1] has started emitting an error in the custom qasm pygments lexer included in qiskit in OpenQASMLexer. In the interest of not blocking CI this commit pins the pygments version we're installing in CI. Longer term, we should probably look at just deprecating the qiskit version and just using openqasm-pygments which is the pygments tools for OpenQASM maintained by the openqasm community. [1] https://pypi.org/project/Pygments/2.15.0/
mtreinish
added
type: qa
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
jakelishman
approved these changes
Apr 11, 2023
jakelishman
added
the
stable backport potential
Pull Request Test Coverage Report for Build 4667467554
💛 - Coveralls |
mergify Bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
The recent release of pygments 2.15.0 [1] has started emitting an error in the custom qasm pygments lexer included in qiskit in OpenQASMLexer. In the interest of not blocking CI this commit pins the pygments version we're installing in CI. Longer term, we should probably look at just deprecating the qiskit version and just using openqasm-pygments which is the pygments tools for OpenQASM maintained by the openqasm community. [1] https://pypi.org/project/Pygments/2.15.0/ (cherry picked from commit f623764)
jakelishman
pushed a commit
that referenced
this pull request
Apr 11, 2023
The recent release of pygments 2.15.0 [1] has started emitting an error in the custom qasm pygments lexer included in qiskit in OpenQASMLexer. In the interest of not blocking CI this commit pins the pygments version we're installing in CI. Longer term, we should probably look at just deprecating the qiskit version and just using openqasm-pygments which is the pygments tools for OpenQASM maintained by the openqasm community. [1] https://pypi.org/project/Pygments/2.15.0/ (cherry picked from commit f623764) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
giacomoRanieri
pushed a commit
to giacomoRanieri/qiskit-terra
that referenced
this pull request
Apr 16, 2023
The recent release of pygments 2.15.0 [1] has started emitting an error in the custom qasm pygments lexer included in qiskit in OpenQASMLexer. In the interest of not blocking CI this commit pins the pygments version we're installing in CI. Longer term, we should probably look at just deprecating the qiskit version and just using openqasm-pygments which is the pygments tools for OpenQASM maintained by the openqasm community. [1] https://pypi.org/project/Pygments/2.15.0/
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
The recent release of pygments 2.15.0 [1] has started emitting an error in the custom qasm pygments lexer included in qiskit in OpenQASMLexer. In the interest of not blocking CI this commit pins the pygments version we're installing in CI. Longer term, we should probably look at just deprecating the qiskit version and just using openqasm-pygments which is the pygments tools for OpenQASM maintained by the openqasm community. [1] https://pypi.org/project/Pygments/2.15.0/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The recent release of pygments 2.15.0 [1] has started emitting an error in the custom qasm pygments lexer included in qiskit in OpenQASMLexer. In the interest of not blocking CI this commit pins the pygments version we're installing in CI. Longer term, we should probably look at just deprecating the qiskit version and just using openqasm-pygments which is the pygments tools for OpenQASM maintained by the openqasm community.
Details and comments
[1] https://pypi.org/project/Pygments/2.15.0/