Apply new deprecation decorators to pulse folder#9871
Merged
Eric-Arellano merged 6 commits intoMar 30, 2023
Conversation
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Eric-Arellano
added
the
Changelog: None
nkanazawa1989
suggested changes
Mar 30, 2023
Contributor
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
There is a small typo but LGTM except for this.
1ucian0
added
the
type: qa
…ply-deprecations-pulse
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
…ellano/qiskit-terra into apply-deprecations-pulse
…ply-deprecations-pulse
Pull Request Test Coverage Report for Build 4564031285
💛 - Coveralls |
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Apr 5, 2023
* Apply new deprecation decorators to pulse folder * Update qiskit/pulse/library/parametric_pulses.py Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> * Fix bad use of DeMorgan's law for boolean --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
giacomoRanieri
pushed a commit
to giacomoRanieri/qiskit-terra
that referenced
this pull request
Apr 16, 2023
* Apply new deprecation decorators to pulse folder * Update qiskit/pulse/library/parametric_pulses.py Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> * Fix bad use of DeMorgan's law for boolean --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
10 tasks
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Apply new deprecation decorators to pulse folder * Update qiskit/pulse/library/parametric_pulses.py Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> * Fix bad use of DeMorgan's law for boolean --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See #9676 for the motivation.
Details and comments