Deprecate complex amp support for ScalableSymbolicPulse#10357
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5461949464
💛 - Coveralls |
Contributor
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
Looks almost good to me. Just a few minor suggestions.
Contributor
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thanks for the ping!
Contributor
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
Just minor suggestions for type hints, but this is almost good to go.
nkanazawa1989
approved these changes
Jul 5, 2023
Contributor
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
Thanks @TsafrirA this looks good to go.
github-merge-queue Bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Jul 7, 2023
### Summary This PR removes complex amplitudes from pulses in tests after Qiskit/qiskit#10357.
mergify Bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Aug 25, 2023
### Summary This PR removes complex amplitudes from pulses in tests after Qiskit/qiskit#10357. (cherry picked from commit ad8aa79) # Conflicts: # test/calibration/test_calibrations.py
This was referenced Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We deprecate the support for complex
ampin the initialization ofScalableSymbolicPulse.Details and comments
PR #9002 (and later #9871) issued
PendingDeprecationWarnings for initialization ofScalableSymbolicPulse(and particularly the library pulses which rely on it) with complexamp. The alternativeamp,anglerepresentation was introduced then. This PR promotes the warning to a deprecation warning.