Fix pauli.evolve dtype casting error#8877
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3236028185
💛 - Coveralls |
mtreinish
added
Changelog: Fixed
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, this looks great. I only had one question, but the answer doesn't really matter for merging.
| base_phase = np.mod(cls._phase_from_complex(op.coeff) + _count_y(base_x, base_z), 4) | ||
| base_phase = np.mod( | ||
| cls._phase_from_complex(op.coeff) + _count_y(base_x, base_z), 4, dtype=int | ||
| ) |
There was a problem hiding this comment.
I'm guessing this is int for consistency with other methods in this class?
* Fix pauli phase evolve * Update for unsigned int phases Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e6d23d5)
* Fix pauli phase evolve * Update for unsigned int phases Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e6d23d5) Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
5 participants
Summary
Fixes #8438
Fixes issue where
Pauli.evolveandPauliList.evolvewould raise a dtype error when evolving by certain Clifford gates which modified the Pauli's phase.Details and comments
This fix make it so that rather than cast the dtype of the phase vector to a fixed type, it will accept any signed or unsigned integer dtype and work with that.