Rename run_options to options in fidelity and gradients and fidelity bug fix#8755
Merged
Conversation
ElePT
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
woodsp-ibm
added
mod: algorithms
mod: primitives
ElePT
commented
Sep 14, 2022
ElePT
commented
Sep 14, 2022
ElePT
commented
Sep 15, 2022
ElePT
changed the title
Pull Request Test Coverage Report for Build 3115925932
💛 - Coveralls |
ElePT
commented
Sep 19, 2022
This was referenced Sep 19, 2022
ElePT
commented
Sep 19, 2022
woodsp-ibm
added
the
Changelog: None
woodsp-ibm
approved these changes
Sep 23, 2022
ElePT
added a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
…bug fix (Qiskit#8755) * Rename run_options to options * Update qiskit/algorithms/state_fidelities/base_state_fidelity.py * Update qiskit/algorithms/state_fidelities/base_state_fidelity.py * Update qiskit/algorithms/state_fidelities/compute_uncompute.py * Fix bug * Fix measurements, empty list * Add check empty list * Update test/python/algorithms/state_fidelities/test_compute_uncompute.py * Update test/python/algorithms/state_fidelities/test_compute_uncompute.py * Fix black * Add options properties * fix unit tests Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
added a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
…bug fix (Qiskit/qiskit#8755) * Rename run_options to options * Update qiskit/algorithms/state_fidelities/base_state_fidelity.py * Update qiskit/algorithms/state_fidelities/base_state_fidelity.py * Update qiskit/algorithms/state_fidelities/compute_uncompute.py * Fix bug * Fix measurements, empty list * Add check empty list * Update test/python/algorithms/state_fidelities/test_compute_uncompute.py * Update test/python/algorithms/state_fidelities/test_compute_uncompute.py * Fix black * Add options properties * fix unit tests Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows the new naming convention applied in #8719 and renames
run_optionstooptionsin thestate_fidelitiesandgradientsmodules.Details and comments
Additional changes in this PR:
dicttoOptionsin those files where it had not been applied already_get_local_options()method toComputeUncoputefor consistency with the gradientsoptionsproperty andupdate_default_optionsmethod to gradients and fidelities for consistency with the primitivesComputeUncopute. It now:- checks for existing measurements in input circuits and removes measurements before composing them
- accepts empty parameter value list (
[ ]) on top ofNonefor unparametrized circuits.