Skip to content

Rename run_options to options#8719

Merged
mergify[bot] merged 9 commits into
Qiskit:mainfrom
ikkoham:primitives/rename-run_options1
Sep 14, 2022
Merged

Rename run_options to options#8719
mergify[bot] merged 9 commits into
Qiskit:mainfrom
ikkoham:primitives/rename-run_options1

Conversation

@ikkoham
Copy link
Copy Markdown
Contributor

@ikkoham ikkoham commented Sep 9, 2022

Summary

@jyu00 requested renaming run_options to options for consistency with qiskit-ibm-runtime.

Details and comments

@ikkoham ikkoham requested a review from jyu00 September 9, 2022 04:46
@qiskit-bot
Copy link
Copy Markdown
Collaborator

qiskit-bot commented Sep 9, 2022

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

t-imamichi
t-imamichi previously approved these changes Sep 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikkoham ikkoham added the mod: primitives Related to the Primitives module label Sep 9, 2022
@ikkoham ikkoham mentioned this pull request Sep 9, 2022
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3049854421

  • 15 of 15 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.339%
Totals Coverage Status
Change from base Build 3049697302: 0.0%
Covered Lines: 57960
Relevant Lines: 68723
💛 - Coveralls

@jyu00
Copy link
Copy Markdown
Contributor

jyu00 commented Sep 9, 2022

Just to add more context, I requested the change because a subclass implementation, such as the ones in qiskit-ibm-runtime, can support more than just runtime options. And run_options implies it's only for runtime.

jyu00
jyu00 previously approved these changes Sep 9, 2022
View reviewed changes
t-imamichi
t-imamichi previously approved these changes Sep 12, 2022
View reviewed changes
@t-imamichi
Copy link
Copy Markdown
Member

t-imamichi commented Sep 12, 2022

Could you review this, @woodsp-ibm?

@woodsp-ibm woodsp-ibm added this to the 0.22 milestone Sep 12, 2022
woodsp-ibm
woodsp-ibm reviewed Sep 12, 2022
View reviewed changes
Comment thread qiskit/primitives/base_estimator.py Outdated
Comment thread qiskit/primitives/base_sampler.py Outdated
Comment thread qiskit/primitives/estimator.py Outdated
Comment thread qiskit/primitives/sampler.py Outdated
@ikkoham ikkoham dismissed stale reviews from t-imamichi and jyu00 via e6b8278 September 13, 2022 06:20
@ikkoham ikkoham mentioned this pull request Sep 13, 2022
Merged
@mergify mergify Bot merged commit 66303f0 into Qiskit:main Sep 14, 2022
@ikkoham ikkoham deleted the primitives/rename-run_options1 branch September 14, 2022 07:45
@ElePT ElePT mentioned this pull request Sep 14, 2022
Merged
@woodsp-ibm woodsp-ibm mentioned this pull request Apr 20, 2023
Open
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
@ikkoham @mergify @manoelmarques
Rename run_options to options (Qiskit#8719)
ac37037 
* Rename run_options to options

* fix algorithms

* update docs

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
@ikkoham @mergify @manoelmarques
Rename run_options to options (Qiskit/qiskit#8719)
da513c0 
* Rename run_options to options

* fix algorithms

* update docs

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-imamichi t-imamichi t-imamichi approved these changes

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00

+1 more reviewer

@manoelmarques manoelmarques manoelmarques approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod: primitives Related to the Primitives module

Projects

None yet

Milestone

0.22

Development

Successfully merging this pull request may close these issues.

7 participants

@ikkoham @qiskit-bot @coveralls @jyu00 @t-imamichi @manoelmarques @woodsp-ibm