Implemented PVQD algorithm with primitives.#8705
Merged
Merged
Conversation
added 30 commits
August 30, 2022 13:21
added 2 commits
September 15, 2022 13:28
# Conflicts: # qiskit/algorithms/__init__.py
woodsp-ibm
added
the
Changelog: Added
woodsp-ibm
reviewed
Sep 20, 2022
woodsp-ibm
reviewed
Sep 20, 2022
woodsp-ibm
reviewed
Sep 21, 2022
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
woodsp-ibm
approved these changes
Sep 22, 2022
Member
woodsp-ibm
left a comment
woodsp-ibm
left a comment
There was a problem hiding this comment.
@dlasecki Thanks, LGTM now.
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Implemented observables_evaluator.py with primitives. * Added evolvers problems and interfaces to time_evolvers package. * Mostly updated trotter_qrte.py to use primitives. * Added observables_evaluator.py that uses primitives. * Added observables_evaluator.py that uses primitives. * Updated trotter_qrte.py to use primitives. * Updated imports * Added estimator to pvqd.py (draft) * Updated typehints and limited use of opflow. * Updated typehints and limited use of opflow. * Removed files out of scope for this PR. * Added annotations import. * Added observables_evaluator.py with primitives. * Added ListOrDict support to observables_evaluator.py. * Drafted pvqd.py with the fidelity primitive; type hints updated. * Accepting fidelity primitive. * Included CR suggestions. * Applied some CR comments. * Applied some CR comments. * Added reno. * Added reno. * Accepting Statevector. * Added attributes docs. * Support for 0 operator. * Implemented pvqd unit tests with primitives; code refactoring. * Added reno. * Updated algorithms init. * Code refactoring. * Removed old pvqd algorithm and related files. * Add pending deprecation for evolvers * Renamed classes and linked to algorithms init. * fix docstring * Improved reno. * Updated classes names. * Code refactoring. * Applied CR comments. * Removed unnecessary files. * Applied CR comments. * Black fix. * Applied CR comments. * Init updates. * Reduced number of cyclic import. * Fix for cyclic import * Doc fix * Updated init. * Added error raising and unit test. * Apply suggestions from code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Fixed code example. Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com> Co-authored-by: woodsp-ibm <woodsp@us.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Implemented observables_evaluator.py with primitives. * Added evolvers problems and interfaces to time_evolvers package. * Mostly updated trotter_qrte.py to use primitives. * Added observables_evaluator.py that uses primitives. * Added observables_evaluator.py that uses primitives. * Updated trotter_qrte.py to use primitives. * Updated imports * Added estimator to pvqd.py (draft) * Updated typehints and limited use of opflow. * Updated typehints and limited use of opflow. * Removed files out of scope for this PR. * Added annotations import. * Added observables_evaluator.py with primitives. * Added ListOrDict support to observables_evaluator.py. * Drafted pvqd.py with the fidelity primitive; type hints updated. * Accepting fidelity primitive. * Included CR suggestions. * Applied some CR comments. * Applied some CR comments. * Added reno. * Added reno. * Accepting Statevector. * Added attributes docs. * Support for 0 operator. * Implemented pvqd unit tests with primitives; code refactoring. * Added reno. * Updated algorithms init. * Code refactoring. * Removed old pvqd algorithm and related files. * Add pending deprecation for evolvers * Renamed classes and linked to algorithms init. * fix docstring * Improved reno. * Updated classes names. * Code refactoring. * Applied CR comments. * Removed unnecessary files. * Applied CR comments. * Black fix. * Applied CR comments. * Init updates. * Reduced number of cyclic import. * Fix for cyclic import * Doc fix * Updated init. * Added error raising and unit test. * Apply suggestions from code review Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Fixed code example. Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com> Co-authored-by: woodsp-ibm <woodsp@us.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Projected Variational Quantum Dynamics algorithm with primitives.
Removes the old algorithm.
Closes: #8489
Details and comments
This PR is blocked by #8681 and #8683 PRs and the current draft includes files from those PRs as they are necessary for the algorithm to run. Please ignore these files while reviewing this PR.
No deprecation needed for the old version because it was never released.